Doma APT module-info.java is missing `provides javax.annotation.processing.Processor` about doma

[agentgt]

After testing it doesn't really matter. Ultimately because of the way this library is designed you have to use:

<annotationProcessorPaths>
....
</<annotationProcessorPaths>

instead of just

<dependencies>
<dependency> dom apt as optional and provided </dependency>
</dependencies>

Because org.seasar.doma.processor can only be put on the classpath as that is all both Maven and Gradle support for APT (javac actually supports APT with modulepath) doma.core needs to as well. What happens though is doma.core will be on the module path in a modular environment.

The reason annotationProcessorPaths works is that Maven will put the doma.core dependency into the classpath as well as the modulepath but I warn you this can have weird results.

In my library https://github.com/jstachio/jstachio you do not have to use annotationProcessorPaths and let the compiler discover precisely because I make sure every dependencies is shaded in and never access the annotations directly.

I highly recommend you consider shading doma.core into the doma.processor to avoid issues you like this. Ideally the annotations should be in their own jar as well.

---

With all that being said you should still correct the module-info.java in case someone does use javac --processor-module-path

[nakamura-to]

Thanks for your feedback.

I highly recommend you consider shading doma.core into the doma.processor to avoid issues you like this. Ideally the annotations should be in their own jar as well.

I will consider it in a future version.

[nakamura-to]

Shadow jar support was addressed in #992