[traceDetailsView] selecting traces causes entire view to break but only in production mode about dbux

[Domiii]

Problem not being reported is a problem with VSCode. It is most likely happening after we returned newly created nodes from BaseTreeViewNodeProvider.getChildren, and VSCode is unable to add them and the error is not thrown and just gobbled up. VSCode should log this properly or throw an error when calling _onDidChangeTreeData.fire() which is the ultimate caller of a tree refresh (the latter probably cannot happen because it is probably an asynchronous action). Issue has been causing quite a lot of unhappiness and (probably incorrectly) marked as resolved in microsoft/vscode#71698.

While this is a general VSCode problem, it still hints at a bug in our code.

That bug is caused by our node id generation not generating unique node ids here:

  makeNodeId(nodeClassName, parent, i) {
    return [parent?.id || '', nodeClassName, i].join('..');
  }

Specifically, in production, nodeClassName is null or undefined or empty string, causing trouble.

[Domiii]

Fixed by generating a unique id for each NodeClass and use that instead of (in addition to) just the name:

const nodeClasses = new Map();

function makeNodeClassId(NodeClass) {
  // in production, names get mangled and/or removed entirely, so we need a different class identifier here
  let id = nodeClasses.get(NodeClass);
  if (!id) {
    id = nodeClasses.size + 1;
    nodeClasses.set(NodeClass, id);
  }
  
  return (NodeClass.name || '') + id;
}