GithubHelp home page GithubHelp logo

Comments (1)

f0k avatar f0k commented on July 3, 2024

Thank you for your report! First of all, is there a specific reason you need to build this with VS? The README file includes a guide for compiling with mingw: https://github.com/dominikschnitzer/musly#installation

Otherwise, your list is a mix of things we can or should change universally (const buffer_size, && instead of and, not defining uint8_t, #include <algorithm>), and things that are specific to VS (_USE_MATH_DEFINES, NOMINMAX). The latter would require some CMake magic to automatically add those defines if compiling with VS. Or actually, NOMINMAX should probably just be defined before include <windows.h>. Would you be willing to send a PR with the required changes to make it work in VS (without breaking compilation on Linux -- I can check that)?

About the BUILD_STATIC option, does #32 help?

from musly.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.