GithubHelp home page GithubHelp logo

Configurable currency for price about spoolman HOT 6 CLOSED

donkie avatar donkie commented on August 29, 2024 1
Configurable currency for price

from spoolman.

Comments (6)

zellneralex avatar zellneralex commented on August 29, 2024

That is not as easy as it sounds. I would simple add a field where the User can add a current sign. Otherwise you will get complains that (put currency here) is missing.

more important you need the price per spool and not per filament. As an example I use a lot of eSun black abs+ and the spool varies between 18-21 EUR so currently there is no way to set the price of the active spools

from spoolman.

Donkie avatar Donkie commented on August 29, 2024

You'd input your currency with the currency code like EUR. There are libraries which support most if not all currencies out there. It's not just as easy as having a field where people can slap on the currency sign, since different currencies have different ways of formatting the money. Some have the currency sign before the value, some have after, for example.

My idea for it being on the filament level is that it would just be the "general" price of it, so you have a general understanding how much a print would cost for example, not for it to be an exact science. It could be a bit annoying having to input it for every spool.

But I guess I could keep the price on the filament, and just add a price on the spool as well, and if the spool price isn't set, the filament price would be used instead.

from spoolman.

zellneralex avatar zellneralex commented on August 29, 2024

You can ask mete I am all in for units. My point is that you will find regions that buy it in more than on currency.
we in Europe are mostly lucky that you can buy it mostly in EUR but consider other regions where the buy it from different countries in different currencies.

But I guess I could keep the price on the filament, and just add a price on the spool as well, and if the spool price isn't set, the filament price would be used instead.
AZ: that is a good compromise.

I think about the UI here, where we could show the filament price in the history tab as long we know the length, density used spool and price per spool.
Length is already there so we might need to add used spool ID to the moonraker meta data. Price and density could be queried at run time.

from spoolman.

Donkie avatar Donkie commented on August 29, 2024

I think then if you're buying with multiple currencies, and you want to track the costs using Spoolman, you would have to do a currency conversion to one standard currency manually. If we start to accept multiple different currencies in the same Spoolman instance, it would be very hard to do any cost calculations. Thirdparty apps that want to integrate with Spoolman also would need to handle these type of conversions.

I think the benefits outweigh the drawbacks forcing people to use a single currency

from spoolman.

fweber3 avatar fweber3 commented on August 29, 2024

Just looking over the fence a bit: PrusaSlicer takes "single currency" even further. Their hardcoded monetary unit is literally "money" or "money / kg".

What is the actual usecase for the price data? Should that usecase best be implemented in Spoolmanager, or somewhere else? (e.g. a business spreadsheet). These 2 questions should probably provide half the answer.

Apart from that: if it comes to that point, it would probably be nice to let old/new spools have differing prices. Inflation happens, old spools do too. (perhaps that is even already implemented, I do my cost tracking differently anyway).

from spoolman.

Donkie avatar Donkie commented on August 29, 2024

This has now been added

from spoolman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.