GithubHelp home page GithubHelp logo

Remove jsdom dependency about html2jade HOT 4 CLOSED

ming-codes avatar ming-codes commented on June 10, 2024
Remove jsdom dependency

from html2jade.

Comments (4)

donpark avatar donpark commented on June 10, 2024

Interesting suggestion. I used jsdom instead of using htmlparser directly because I wanted to cover javascript generated document as well. Perhaps a good compromise is to use static HTML conversion as default and make dynamic document conversion an option.

from html2jade.

donpark avatar donpark commented on June 10, 2024

I just realized that removing jsdom dependency from html2jade will require adding a htmlparser-specific layer to simulate DOM API which is required to continue supporting convertDocument method.

Given that amount of change is not trivial, I'm going to defer this issue until later. Of course, you are welcome to fork and hack as always if you can't wait. :-)

from html2jade.

donpark avatar donpark commented on June 10, 2024

version 0.7 replaces jsdom with jsdom-little which apparently don't have problematic contextify dependency. while not exactly matching this issue, it's a move in the right direction.

@Lightblade Please close this issue if you feel your needs are met. Leave it as is otherwise. Thx.

from html2jade.

ming-codes avatar ming-codes commented on June 10, 2024

Sure. Thanks for getting that out.

from html2jade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.