GithubHelp home page GithubHelp logo

Comments (10)

Voros2 avatar Voros2 commented on August 25, 2024

I'm surprised it doesn't. This wouldn't be related to the fact that Deutex always looks for the TEXTURE lumps in the IWAD first, would it?

from deutex.

Voros2 avatar Voros2 commented on August 25, 2024

Here's some rough code I wrote that should make Deutex not look for the TEXTURE lumps in the IWAD unless specified via -iwad. Problem is IDK what to do with the PNAME section.

from deutex.

fragglet avatar fragglet commented on August 25, 2024

Friendly head-up: It's usually more helpful to link to the commit rather than the file. Otherwise it's very hard to know what you changed.

from deutex.

fragglet avatar fragglet commented on August 25, 2024

But, I think you commented on the wrong bug? Your change looks like it's related to #7 and probably unrelated to this issue.

from deutex.

Voros2 avatar Voros2 commented on August 25, 2024

Chances are they are both related.

from deutex.

fragglet avatar fragglet commented on August 25, 2024

I see no reason to think so.

from deutex.

fragglet avatar fragglet commented on August 25, 2024

Confirmed. It's an unrelated issue. CMPOmakePWAD() does this:

        while (TXTentryParse
               (name, filenam, &X, &Y, &Repeat, TXT, false) == true) {

TXTentryParse() is a standard function that parses lines from the config file. The filenam variable is populated, but the value isn't actually used. It goes on to just construct the filename ignoring it:

            if (MakeFileName
                (file, DataDir, "TEXTURES", "", name, "TXT") == true) {
                Detail("CM52", "Reading texture file %s", fname(file));
                TXUreadTexFile(file, true);

There's also a ton of duplicated code that's identical between TEXTURE1 and TEXTURE2. This is a horrible codebase.

from deutex.

Voros2 avatar Voros2 commented on August 25, 2024

Then simply changing name to filenam should fix it. That's how the other composing functions do it.

from deutex.

chungy avatar chungy commented on August 25, 2024

This is a horrible codebase.

Yes it is. ;)

from deutex.

chungy avatar chungy commented on August 25, 2024

Fixed as of a233972

from deutex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.