Anyway to have highlight indentation part of the theme ? about themes

[hlissner]

Hey there! And thanks, I'm glad you like it.

You can replace def-package! with use-package. They're aliases. It's there just for consistency (with my emacs.d) and in case I need to wrap use-package in some functionality later. add-hook! is a convenience macro for adding 1-to-many, many-to-many, or many-to-1 functions to hooks. In any case, here is my config without any of my private macros:

(use-package highlight-indentation
  :commands (highlight-indentation-mode highlight-indentation-current-column-mode)
  :config
  (defun doom|inject-trailing-whitespace (&optional start end)
    "The opposite of `delete-trailing-whitespace'. Injects whitespace into
buffer so that `highlight-indentation-mode' will display uninterrupted indent
markers. This whitespace is stripped out on save, as not to affect the resulting
file."
    (interactive (progn (barf-if-buffer-read-only)
                        (if (use-region-p)
                            (list (region-beginning) (region-end))
                          (list nil nil))))
    (unless indent-tabs-mode
      (save-match-data
        (save-excursion
          (let ((end-marker (copy-marker (or end (point-max))))
                (start (or start (point-min))))
            (goto-char start)
            (while (and (re-search-forward "^$" end-marker t) (< (point) end-marker))
              (let (line-start line-end next-start next-end)
                (save-excursion
                  ;; Check previous line indent
                  (forward-line -1)
                  (setq line-start (point)
                        line-end (save-excursion (back-to-indentation) (point)))
                  ;; Check next line indent
                  (forward-line 2)
                  (setq next-start (point)
                        next-end (save-excursion (back-to-indentation) (point)))
                  ;; Back to origin
                  (forward-line -1)
                  ;; Adjust indent
                  (let* ((line-indent (- line-end line-start))
                         (next-indent (- next-end next-start))
                         (indent (min line-indent next-indent)))
                    (insert (make-string (if (zerop indent) 0 (1+ indent)) ? )))))
              (forward-line 1)))))
      (set-buffer-modified-p nil))
  nil)

  (defun highlight-indentation-handle-whitespace ()
    (if (or highlight-indentation-mode highlight-indentation-current-column-mode)
        (progn
          (doom|inject-trailing-whitespace)
          (add-hook 'before-save-hook #'delete-trailing-whitespace nil t)
          (add-hook 'after-save-hook #'doom|inject-trailing-whitespace nil t))
      (remove-hook 'before-save-hook #'delete-trailing-whitespace t)
      (remove-hook 'after-save-hook #'doom|inject-trailing-whitespace t)
      (delete-trailing-whitespace)))
  (add-hook 'highlight-indentation-mode-hook 'highlight-indentation-handle-whitespace)
  (add-hook 'highlight-indentation-current-column-mode-hook 'highlight-indentation-handle-whitespace)

However, I must disagree with adding highlight-indentation to doom-themes. There are multiple such plugins, each with their own pros and cons for different languages; I can't suppot all of them nor can I presume to guess every user's needs. I also think it's trivial enough for a user to implement themselves (my config notwithstanding).

doom-one does set the highlight indentation faces however (so they'll be colored appropriately if you do use any of those plugins).

[jwintz]

Many thanks ! Works like a charm.