Comments (11)
This was caused by doom-buffer-mode
. I've reverted the last update, but I'm confused: I see you're using a light theme. If you are switching themes (between a doom theme and a non-doom-theme), then doom-buffer-mode
will overwrite that theme's org-hide face.
I'll include some checks in a future fix to ensure that doesn't happen.
from themes.
Ah thank you, after the last melpa update it seems to work. The light theme is only for viewing mails because with doom theme enabled they look like this (see the black font inline), btw. text mails are fine it's only with some (not all) html mails, I don't know why. With other dark themes it's the same...
from themes.
My hunch is, in the email's HTML, the text is colored black, which Emacs translates into black text.
I realize this is unrelated to the issue here, but would you mind running the following while your point is on the black text?
(let ((hl-line-p (bound-and-true-p hl-line-mode)))
(if hl-line-p (hl-line-mode -1))
(let ((face (or (get-char-property (point) 'read-face-name)
(get-char-property (point) 'face))))
(if face (message "Face: %s" face) (message "No face at %d" (point))))
(if hl-line-p (hl-line-mode 1)))
That should tell me if there's anything I can do about it on doom-themes' end (specifically, it'll tell me what faces are being applied to that text; where it might be coming from).
from themes.
Of course, thanks for the help, this is the output
Invalid face reference: nil [67 times]
Face: (variable-pitch (:foreground #000000) mu4e-view-body-face)
Invalid face reference: nil [10 times]
QuitInvalid face reference: nil
Invalid face reference: nil [5 times]
from themes.
I think I know what the problem is. If you're using a version of Emacs older than 25.0, then mu4e may be using the older html2text
package to render html. It's not intelligent about color collisions with your active Emacs theme.
Newer versions of Emacs has the shr
library (built-in) to render HTML, which has a fix for this issue.
If you check the variable mu4e-html2text-command
, and if it contains html2text
, then my hunch is correct and the only way to fix it is to upgrade Emacs.
Unfortunately, I don't know in what version of Emacs shr
was introduced, but I haven't had an issue with dark text on dark backgrounds since 25.0 (and am now using 25.2), so I assume v25+ is safe.
from themes.
Anyhow, I've fixed the original issue (with org-hide), so I'll close this. Feel free to email me (address is in my profile) to follow up on the email problem, if you'd like.
from themes.
Hi, when solaire-mode
is on, doom still doesn't hide leading stars in terminal mode.
from themes.
@amosbird Just pushed a possible fix for that. Please check it out and let me know if it resolves your issue.
from themes.
@hlissner Thanks! Hmm, how can I use this in doom-emacs?
from themes.
@amosbird Run make update
to update Doom's plugins, including this one. Then restart Emacs and you should see the changes.
from themes.
Ah, it works fine now. Thanks!
from themes.
Related Issues (20)
- The color of function parameter is not correct HOT 3
- Line numbers in doom-monokai-pro theme are barely visible. HOT 1
- spacegrey org mode headings are hard to distinguish from text
- Files named .project in emacs have treemacs icons that are green and twice as big as others HOT 3
- [Theme request] inky color scheme flexoki
- Support `gud-highlight-current-line-face`
- Org fontification extension assumes org-indent is loaded
- [Theme request] Everforest port
- `:box` attribute `:style none` is invalid in latest Emacs 30 HOT 1
- Warning: nil value is invalid, use ‘unspecified’ instead HOT 3
- error while installing the badger theme HOT 1
- Add support for icons in lsp symbols and breadcrumbs HOT 1
- Slant inconsistent in solarized-light vs solarized-dark HOT 1
- Getting error while installing doom emacs theme.
- Support treemacs-ext with nerd-icons instead of all-the-icons HOT 2
- solarized-light: org mode 8th bullet indentation barely readable
- Low contrast while using lsp with solarized-light HOT 1
- Add tokyo-night storm and moon HOT 3
- Colours are different in Emacs and Emacsclient HOT 3
- "Ansi bright black" color is never readable as a foreground color HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from themes.