Make modeline styling optional about themes

[hlissner]

I'm guessing you are a doom-buffer-mode user, and you're bothered that it changes the mode-line when you activate/deactivate that mode?

If you aren't (a doom-buffer-mode user), then perhaps you literally mean my changes are overriding yours? I see a bunch of set-face-attributes in your emacs.d. Are these somehow being overwritten?

[etyurkin]

Nope, here's my modeline config (https://github.com/etyurkin/emacs.d/blob/master/config.org#init-main-theme):

(set-face-attribute 'mode-line nil :foreground "gray" :background nil :box nil)
(set-face-attribute 'mode-line-inactive nil :foreground "SkyBlue4" :background nil :box nil)
(set-face-attribute 'powerline-active1 nil :foreground "SkyBlue1" :background "SkyBlue4")
(set-face-attribute 'powerline-active2 nil :foreground "white" :background nil)
(set-face-attribute 'powerline-inactive1 nil :foreground "SkyBlue4" :background nil)
(set-face-attribute 'powerline-inactive2 nil :foreground "SkyBlue4" :background nil)
(set-face-attribute 'spaceline-highlight-face nil :foreground "SkyBlue1" :background "SkyBlue4")

(setq powerline-default-separator 'curve)
(spaceline-emacs-theme)

It gives me nice curved separators, but if I activate doom-one theme it overrides these values and it doesn't look as I want anymore. I can set these values after theme activation and it works fine when emacs is starting but breaks every time doom package is updated.

The workaround I currently have is I moved modeline initialization into interactive function and call it after doom package updates.

[hlissner]

Try custom-set-faces instead, as it doesn't get overwritten when the theme is reloaded:

(custom-set-faces
   `(mode-line                ((t (:foreground "red"      :background nil))))
   `(mode-line-inactive       ((t (:foreground "red"      :background nil :box nil))))
   `(powerline-active1        ((t (:foreground "red"      :background "SkyBlue4"))))
   `(powerline-active2        ((t (:foreground "white"    :background nil))))
   `(powerline-inactive1      ((t (:foreground "SkyBlue4" :background nil))))
   `(powerline-inactive2      ((t (:foreground "SkyBlue4" :background nil))))
   `(spaceline-highlight-face ((t (:foreground "SkyBlue1" :background "SkyBlue4")))))

[hlissner]

Another alternative:

  (defun apply-theme (&rest _)
    ;; put your apply-theme config here
    )
  (advice-add #'load-theme :after #'apply-theme)

Then whenever you reload your theme, apply-theme will run automatically.

(Should be done before your first (load-them 'doom-one t))

[etyurkin]

That works, thanks!