App crashes when sending feedback on iOS 12.5.3 about ios-sdk

[manavo]

Hi @MarkBorazio, sorry for the trouble here!

Just to get the easy ones answered first:

1. The response doesn't return the app key, but when you print/debug the response it shows the URL which was called, and that has the key shown there. The HTTP response from the server doesn't return the key again.
2. The Invalid invocation, missing JSONP callback issue is that opening the endpoint in the browser makes a GET request to that endpoint, whereas the iOS SDK makes a POST request.

I'm not sure about the crash itself, I'll see if I can test and see why that's happening. That line certainly looks innocent enough!

Is the debug response you've included here from the iOS 12 device that always crashes?

Thanks,
Phil

[MarkBorazio]

@manavo
Good to know about those two points.

Yes, the debug response is from the iOS 12 device (when it had crashed).

[manavo]

I've just tried to run it, but with adding support for dark mode it has set the minimum platform version to 13 now.

So on a 12.4 simulator I can't even run a demo app which includes Doorbell's SDK.

[MarkBorazio]

From what I can see, the only reason iOS 13 is a minimum requirement is because we are using colours only available on iOS 13 and above.
It should be pretty easy to fix that up so it uses the old colours when below iOS 13.

If you want, I can create a PR for that and check if it fixes this crashing issue (I should then not have to specify iOS 13 in my podfile).

[manavo]

If you're able to replace the colors with other ones, and still keep working with dark mode, I'd definitely be happy to merge that!

[MarkBorazio]

@manavo
I can confirm that lowering the minimum iOS version fixes the crash.
Here is the PR: #16.

[manavo]

Thanks @MarkBorazio! I'll get it tested and merged next week!

[manavo]

Thanks again for the PR @MarkBorazio! Needed 1 or 2 little adjustments (another change which is only supported from iOS 10 and above), but that's all done now!

[manavo]

Version 0.4.0 has been tagged and released in Cocoapods!