GithubHelp home page GithubHelp logo

Comments (3)

linhdangduy avatar linhdangduy commented on July 1, 2024 2

@toupeira Thank for your attention. I'm happy to propose a PR!

from doorkeeper-openid_connect.

toupeira avatar toupeira commented on July 1, 2024 1

@linhdangduy that's a great question, I don't remember what I had in mind when I originally wrote this 😅

But yes I think adding configuration for this makes sense! 👍

In the default proc we could raise Errors::InvalidConfiguration as the others do, and get rid of Errors::AccountSelectionRequired.

Do you want to submit a PR?

from doorkeeper-openid_connect.

toupeira avatar toupeira commented on July 1, 2024

@linhdangduy oh and BTW there's potential for name clashes in Doorkeeper::OpenidConnect::Helpers::Controller because it's included in other controllers, so I propose we call the method there something like select_account_for_oidc_resource_owner and the configuration value maybe select_account_for_resource_owner, receiving the owner as only argument? Happy with other names too, just the method in the helper should include oidc somewhere.

from doorkeeper-openid_connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.