Unable to delete authorized RP application about doorkeeper-openid_connect

[toupeira]

@truongnmt thanks for the report! 👍

So the foreign key is indeed optional, but protects against accidental data inconsistency, and helps surface bugs like this 😁

I'm happy to switch to dependent: :destroy in Doorkeeper::OpenidConnect::AccessGrant, but it looks like we also need to use :destroy in Doorkeeper::Application. Can you open a corresponding issue in https://github.com/doorkeeper-gem/doorkeeper and ping me there?

[toupeira]

This has come up on GitLab as well: https://gitlab.com/gitlab-org/gitlab/merge_requests/19617

The solution there was to use ON DELETE CASCADE, which is much cleaner and seems to be supported on PostgreSQL/MySQL/SQLite. So I'm planning to add a migration to this gem soon to change the foreign key.

[toupeira]

As discussed in doorkeeper-gem/doorkeeper#1311, it's tricky to switch to dependent: destroy_all in Doorkeeper::Application due to performance concerns.

But I'm happy to accept a PR which implements a monkey-patch along the lines of doorkeeper-gem/doorkeeper#1311 (comment).