[Bug] 2.70.1 causes random NullReferenceException failures with custom templates. about docfx

[gregsdennis]

Hello.

So while investigating ☝️ I found an issue with your meta-schema. Primarily, JSON Schema draft 6 uses $id (with a $) not id as its identifying keyword. This is a change from draft 4, and I suspect it's likely a typo during any conversion that may have occurred. As it is, id is just skipped as an unknown keyword. This is not new behavior.

I'd still like to get an actual minimal reproduction of this bug. My analysis (of my code) indicates that the variable in that code should never be null, which means something before that is wrong. The exception that's actually thrown doesn't help me as literally every keyword generates a KeywordEvaluation object.

Also, I'm not sure why:

• you've written your meta-schema as draft 6, but you're using draft 7 on this line
• you've decided to re-register draft 7 under a new URI

[gregsdennis]

Upcoming JsonSchema.Net v5.2.5 (now published) should fix the issue.

Would still be good to address the issues above.

[yufeih]

Thank you @gregsdennis ! I updated the problems with meta schema according to your findings.