Exec task: unicode support about msbuild

[akoeplinger]

See XMakeTasks/Exec.cs#L280-L285 for some background info.

[v-yadli]

@akoeplinger I've already read that. For my current task I'm attempting to derive from the Exec task. Will get back to report if it works.

There are other issues with Exec.cs as well: dotnet/roslyn#575 (comment). The xplat branch is also having cmd.exe.

For my current task I'm attempting to derive from the Exec task. Will get back to report if it works.

@jaredpar, @mmitche, I think probably the efforts can be converged here, either to make class Exec aware of environment and culture specifics or sub-class Exec/ToolTaskExtension to form NetExec?

[akoeplinger]

@jasonwilliams200OK That is just the toolname, the actual executable is retrieved as "sh" here: Exec.cs#L582

[v-yadli]

It's ugly...

        protected override int ExecuteTool(string pathToTool, string responseFileCommands, string commandLineCommands)
        {
            /* In ExecuteTool Exec will attempt to delete the 'script file'.
             * That would cause an exception for sure. However,
             * we could not derive from its base, nor can we invoke
             * base.base.ExecuteTool. So we make a dummy file for it
             * to delete. To do this, we invoke base's AddCommandLineCommands
             * so that it calls CreateTemporaryBatchFile. Since the base's base
             * already captured our correct parameters, it is safe to hack it.
             */
            this.Command = "TSLCompileTask"; // This will trick VS to display "The command 'TSLCompileTask' failed with code..." on error.
            Microsoft.Build.Tasks.CommandLineBuilderExtension commandLine = new CommandLineBuilderExtension();
            base.AddCommandLineCommands(commandLine);

            return base.ExecuteTool(pathToTool, responseFileCommands, commandLineCommands);
        }

But at least it works -____-"

[AndyGerlicher]

Marking as up-for-grabs as this is something we would like to have working correctly.

[akoeplinger]

@v-yadli Some work was done in #143 to address this, can you check if that fixes your problem as well?

[rainersigwald]

I'm going to mark this as closed since the fix went in last year.