Can only build Roslyn.sln a single time before building breaks (2) about roslyn

[jjonescz]

The main error seems to be

CSC error CS8102: Public signing was specified and requires a public key, but no public key was specified. [D:\roslyn-D\src\VisualStudio\CSharp\Impl\Microsoft.VisualStudio.LanguageServices.CSharp.csproj]

Indeed in the binlog I can see the key is not provided to csc.

Adding <PublicSign>False</PublicSign> to Microsoft.VisualStudio.LanguageServices.CSharp.csproj is one way to work around the problem (but not sure if it doesn't cause other issues).

It seems the underlying bug is that CoreCompile target uses the KeyOriginatorFile property which is set by target ResolveKeySource but that target is not a dependency of CoreCompile (although it's a dependency of CoreBuild and Compile). Most of the time, the ResolveKeySource actually runs before CoreCompile so it works fine, but not in this case (not sure why exactly).

So adding <CoreCompileDependsOn>$(CoreCompileDependsOn);ResolveKeySource</CoreCompileDependsOn> somewhere works around the problem.

I've opened an issue at MSBuild: dotnet/msbuild#10306
And a workaround here: #74205

Outdated

In Error List I see this additional error (but not always, so might be unrelated/flaky thing):

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error (active)	VSSDK1044	Could not find project VisualStudioSetup referenced from source.extension.vsixmanifest. Please add a ProjectReference to VisualStudioSetup or correct project name in source.extension.vsixmanifest.	ExpressionEvaluatorPackage, Microsoft.VisualStudio.IntegrationTest.Setup	C:\.tools\.nuget\packages\microsoft.vssdk.buildtools\17.9.3137-preview3\tools\vssdk\Microsoft.VsSDK.targets	120

[arkalyanms]

@CyrusNajmabadi is this both cmdline and vs?

[CyrusNajmabadi]

no. just VS> i don't use the command line :)

[arkalyanms]

@jjonescz Compile error + Tiger. Would you scout and transition to next Tiger as necessary?

[CyrusNajmabadi]

Updating priority.