Can't use the Pack command from Visual Studio. PackageProjectUrl is not set about winforms

[AdamYoblick]

I think we want to add this to Microsoft.Private.Winforms.csproj, since that's the special project that does the package creation. :)

[dotMorten]

@AdamYoblick yeah that was my first thought too, but that didn't work. The private one doesn't need it, but won't pack unless the two other ones have it.

[AdamYoblick]

Interesting, that means that the way -pack is working in the arcade sdk is different from the way visual studio packs. Perhaps the arcade sdk is setting some defaults that VS doesn't? Will have to investigate.

[zsd4yr]

^ we should probably surface that we are currently only supporting command line until someone can get the bandwidth to support VS as well?

[dotMorten]

@zsd4yr In the interest of people quickly being able to modify winforms and pack it up for testing, what about the little work around I suggested for now, where we just add a property to each project to make it work? I'd be happy to submit the PR

[AdamYoblick]

I think we need to talk about this as a team. I don't like the idea of adding a package property to each project to get this working, since there's a package csproj specifically for that.

I think a better solution would be, if we absolutely have to, to add the package properties to Directory.Build.Props.

Short term I think thats ok, but long term we need to see what why VS is packing differently than the command line.

[dotMorten]

I think the short term solution to put it in Directory.Build.Props is a good one. I was working on a blogpost how to tweak, build and use a local build, and being able to just rightclick-pack simplifies that story some.
Especially considering that build.cmd doesn't actually seem to be generating any nuget packages like the pack option does (unless I'm missing something?)

[AdamYoblick]

Just pass -pack to build.cmd and you will get your package :)

[AdamYoblick]

(am writing the docs on this currently but they are not committed yet)

[dotMorten]

Also it fails from command-line with the exact same issue:

[AdamYoblick]

That's odd, I'm not seeing that when I run .\build -test -pack -sign with latest from master, and our CI build runs -pack every time.

...
Successfully created package 'E:\src\repos\github\winforms\artifacts\packages\Debug\Shipping\Microsoft.Private.Winforms.1.0.0-dev.nupkg'.
SignToolTask starting.
DryRun: True
Signing mode: Real
MicroBuild signing logs will be in (Signing*.binlog): E:\src\repos\github\winforms\artifacts\log\Debug
MicroBuild signing configuration will be in (Round*.proj): E:\src\repos\github\winforms\artifacts\tmp\Debug
Signing Round 0: 15 files to sign.
Signing Round 1: 1 files to sign.
Build artifacts signed and validated.
SignToolTask execution finished.

Build succeeded.
0 Warning(s)
0 Error(s)

[dotMorten]

I tried it from a completely new clone. I'm also seeing it happening in the WPF repo. I'm on VS15.9.0 and very latest coresdk

[dotMorten]

Odd... Not reproducing it on a second PC also on 15.9.0. Even works from within VS. I'm going to chalk it up as something went bad on this PC. Sorry about that. Closing.

[AdamYoblick]

Not a problem at all, happy to hear :)