GithubHelp home page GithubHelp logo

Comments (9)

jernaumorat avatar jernaumorat commented on May 18, 2024

I don't honestly see why that is an issue. They're there to be bought, let the people buy them. As long as it isn't enabling duplication or another kind of exploitation, it isn't an actual issue.

from adarkroom.

Continuities avatar Continuities commented on May 18, 2024

I'm with @vermilingua on this one. Closing the dialog automatically is a no-go, since ADR is based around idling. We can't punish the player for taking too long to revisit the tab. I don't think this issue is gamebreaking, and this is probably a case of the cure being worse than the disease.

from adarkroom.

anubisthejackle avatar anubisthejackle commented on May 18, 2024

I agree with not closing it automatically. One change to this could be to capture the fur count with the first click of a purchase button, so when the dialog appears they can choose to idle and collect fur, and purchase when they're ready.

On the flip side of this, I'd also be 100% behind making the purchase boxes reactivate if the user idles after they've grayed out. I just feel the way it currently is, we're half in and half out.

from adarkroom.

Continuities avatar Continuities commented on May 18, 2024

That's a good point, @anubisthejackle. I'm totally cool with reactivating them as your resources replenish.

from adarkroom.

jernaumorat avatar jernaumorat commented on May 18, 2024

Could you clarify? To me at least, it isn't entirely clear what you're getting at. Do you want only a set amount of goods bought, based off the initial count of fur; or do you want the button to de/reactivate based on the current fur count?

from adarkroom.

Continuities avatar Continuities commented on May 18, 2024

The second one. The buttons already disable when you can't afford the purchase, but they don't enable again as your resources increase while the dialog is open.

from adarkroom.

jernaumorat avatar jernaumorat commented on May 18, 2024

Ah right,I wasn't aware of that, I always bought/$SMed the trading Post in
whenever it was needed.
On 16/07/2014 12:05 AM, "Michael Townsend" [email protected] wrote:

The second one. The buttons already disable when you can't afford the
purchase, but they don't enable again as your resources increase while the
dialog is open.


Reply to this email directly or view it on GitHub
https://github.com/Continuities/adarkroom/issues/108#issuecomment-49036017
.

from adarkroom.

anubisthejackle avatar anubisthejackle commented on May 18, 2024

Issue fixed with Pull request #120 so closing ticket out.

from adarkroom.

groteworld avatar groteworld commented on May 18, 2024

as a bit of Github-Fu if you say something like resolves #120 or closes #120, it will auto close it on merge. Thought that will help!

from adarkroom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.