GithubHelp home page GithubHelp logo

Comments (5)

andrewhao avatar andrewhao commented on July 19, 2024

Hi @moveson - thanks for your feedback. I believe you're correct - pythagorean distance is not useful for nearly all use cases (unless someone here chimes in otherwise). I'll take that into consideration that we may want to delete the method, or at least update the documentation.

from gpx.

moveson avatar moveson commented on July 19, 2024

That sounds good. To be clear, though, the method in its current state is not useful in any case. I spent a bit of time figuring out that it was broken, and then I spent quite a bit more time figuring out why it was broken. I'd like to avoid others spending that unnecessary time.

I'm happy to make the changes and submit a PR if that would be helpful.

from gpx.

andrewhao avatar andrewhao commented on July 19, 2024

If you could make a PR, that would be great. Thanks!

from gpx.

moveson avatar moveson commented on July 19, 2024

If you would authorize me to push to a new branch, I'll make a PR.

from gpx.

andrewhao avatar andrewhao commented on July 19, 2024

Hey @moveson - typically we accept PRs from forks - please feel free to fork this repo, make a change on a branch and open a PR from there. Thank you!

from gpx.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.