Comments (5)
Hi @moveson - thanks for your feedback. I believe you're correct - pythagorean distance is not useful for nearly all use cases (unless someone here chimes in otherwise). I'll take that into consideration that we may want to delete the method, or at least update the documentation.
from gpx.
That sounds good. To be clear, though, the method in its current state is not useful in any case. I spent a bit of time figuring out that it was broken, and then I spent quite a bit more time figuring out why it was broken. I'd like to avoid others spending that unnecessary time.
I'm happy to make the changes and submit a PR if that would be helpful.
from gpx.
If you could make a PR, that would be great. Thanks!
from gpx.
If you would authorize me to push to a new branch, I'll make a PR.
from gpx.
Hey @moveson - typically we accept PRs from forks - please feel free to fork this repo, make a change on a branch and open a PR from there. Thank you!
from gpx.
Related Issues (16)
- Dosen't work with Ruby Enterprise Edition HOT 2
- Change track duration calculation HOT 1
- bump version to 0.9 and publish it to rubygems HOT 3
- earliest_point and latest_point not set when GPX file contains no time information
- Yanked v0.8 HOT 1
- The problem with parsing file HOT 1
- is there a way to it gpx to parse the garmin extension? HOT 3
- gpx installs latest version of nokogiri which is broken on Mac OS HOT 1
- adding to the namespace for output files HOT 2
- Ability to get the lat max/min, lon max/min HOT 1
- Accept StringIO and TempFile HOT 1
- New contributors? HOT 7
- GPX to geoJson HOT 2
- New release? HOT 3
- Would you consider changing the license on the library? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gpx.