Support request ID about serverless-http

[dougmoscrop]

Yes, agreed.

Perhaps via options we could do:

• true (default, inject as X-Request-ID)
• false (don't do anything)
• string (header to inject as)

[rochdev]

I don't think true is needed in that case. Could just be:

• string (defaults to X-Request-ID)
• false (disable)

[dougmoscrop]

Yeah. I just meant if someone sent true I would just convert it rather than throw an error ;)

[dougmoscrop]

Ok, I've implemented this. I didn't bother with true, you were right :)

[rochdev]

@dougmoscrop Any idea when this will land? I want to get going on #11 but since both features introduce an options parameter I'd rather wait for this to be merged.

[dougmoscrop]

Will do today!

…

On Mon, Jan 30, 2017, 7:51 AM Roch Devost ***@***.***> wrote: @dougmoscrop <https://github.com/dougmoscrop> Any idea when this will land? I want to get going on #11 <#11> but since both features introduce an options parameter I'd rather wait for this to be merged. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjzFEQn6emZ19LryA3bwzmEA04_ptRbks5rXdzRgaJpZM4LrOjY> .

[dougmoscrop]

Done via 1.3

[rochdev]

@dougmoscrop I don't think mutating the event object directly is recommended. Would it be possible to add the header directly to the request object instead?

[dougmoscrop]

Refactored to avoid mutating event object:

6b8669c