Comments (4)
Funny you should mention this bug, yesterday afternoon we (Dan and I) had a
two+ hour
conversation directly related to that very function. We did not notice nor
anticipated the exception being thrown, and that's an easy fix to make, but the
root
of the problem is much more complicated... supporting the functionality across
all
Timezones globally.
I'm not entirely sure why/how the isDST function made it into core.js anyways.
Best I
can tell, we don't need it, we're not using it anywhere and obviously it was
originally built as just a stub.
There are several major problems with the JavaScript implementation of DST and
Timezones. Some being critical bugs that have gone unnoticed since JavaScript's
inception.
Combine those problems with the performance problems of the native Date object
and
we're being forced down the road of creating a whole new implementation of the
Date
object. That's not something I'm particularly looking forward to. There's been
some
discussion around this topic in the datejs forums
(http://www.datejs.com/forums/,
search for "Date2" if you're interested.
At the moment my opinion is the isDST() function will have to be moved into our
future Date2 implementation. That would mean removing the function completely
from
the current Datejs core.
I will publish a fix to solve the exception, and thankfully the function can
stand on
it's own, so removing from the core is less of an issue.
If we completely remove from the master source, anyone currently using isDST
can add
the patched function to their own library or manually tack it onto their
version of
date.js.
That is not a final decision. We have to discuss some more and I need to sleep
on the
decision before committing.
Original comment by geoff%[email protected]
on 19 Dec 2007 at 8:03
from datejs.
Changed the Title to "isDST() broken".
It was improperly named "isDate() broken".
Original comment by geoff%[email protected]
on 20 Dec 2007 at 12:15
- Changed title: isDST() broken
from datejs.
We are removing the .isDST() function from the library. At least for the short
term.
There are several other related functions we would like to add, although I
think we
might group them all (including .isDST) into an optional module.
I'm marking this issue as [FIXED], although that's not exactly the best
description.
Basically we're just going to implement and expand on the function in a later
build.
Original comment by geoff%[email protected]
on 20 Dec 2007 at 12:20
- Changed title: [FIXED/FUTURE] isDST() broken
- Changed state: Fixed
from datejs.
For posterity, here's the last version of .isDST().
/**
* Determine whether Daylight Saving Time (DST) is in effect
* @return {Boolean} True if DST is in effect.
*/
$P.isDST = function () {
/* TODO: not sure if this is portable ... get from Date.CultureInfo? */
return this.toString().match(/(E|C|M|P)(S|D)T/)[2] == "D";
};
Original comment by geoff%[email protected]
on 20 Dec 2007 at 12:22
from datejs.
Related Issues (20)
- Date.parse() on RFC 3339 Format Date Time yields a null object in IE 10 only
- Date.parse("2011-W12") does not work
- add functions not working at daylight savings boundary
- Uncaught TypeError: Object [object Date] has no method 'getISOWeek' HOT 1
- fa-IR jalali shamsi support is not working
- Add quarter to format strings HOT 1
- it-IT.js error in date format . instead of : H.mm instead of H:mm HOT 2
- Date.parse() seems to mix up day and month HOT 1
- add().days().toString() returns different dates depending on format chosen
- parsing fail for date '1997-07-16T19:20:30+01:00', '1985-04-12T23:20:50Z'
- Date.getTimezoneAbbreviation is wrong
- Patch for /trunk/src/globalization/id-ID.js
- when you do var dt2=dt1.next().sunday(), dt1 itself changes to next sunday
- persian months, days, first day of week, first month, ... do not set properly
- Don't clobber Date.now HOT 2
- Ortography date-es-MX.js
- .addMonths('6') != .addMonths(6). String problem
- Is datajs works on IE
- Standard Formats (single letter formats) are not working correctly HOT 1
- getTimezone returns null
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datejs.