Comments (4)
In my opinion the current behavior generally makes sense, with / indicating that you want the folder itself being included, but I'll just fork this and fix that issue myself then if this feature is not in the scope of this project.
from download-directory.github.io.
Heh, this is undefined behavior. The fact that it behaves differently is a bug: both URLs point to the same resource and should produce the same output. In both cases the result should be the one I showed earlier.
Changing the zip’s structure is out of scope as the zip is just the current vessel to “download a directory” and may change at any time. See for example #94
from download-directory.github.io.
I don’t remember this being an issue, are you on Windows?
This works correctly on iOS, the ZIP file seems to contain the raw contents of the folder, 5 files:
from download-directory.github.io.
I don’t remember this being an issue, are you on Windows?
Yes, I'm on Windows 11 and the issue happens on both Firefox and Edge.
This works correctly on iOS, the ZIP file seems to contain the raw contents of the folder, 5 files:
* [download-directory.github.io/?url=https%3A%2F%2Fgithub.com%2Frefined-github%2Frefined-github%2Ftree%2Fmain%2Fsource%2Fgithub-events](https://download-directory.github.io/?url=https%3A%2F%2Fgithub.com%2Frefined-github%2Frefined-github%2Ftree%2Fmain%2Fsource%2Fgithub-events)
Yes, if I just put the folder link directly it has that behavior, but I do want the folder itself to be in the root of the zip file so I append /
to the url.
For example:
https://download-directory.github.io/?url=https://github.com/AikoMidori/SteamSkins/tree/main/Metro
produces a zip file that contains all of the files in the Metro folder in the root of the zip
https://download-directory.github.io/?url=https://github.com/AikoMidori/SteamSkins/tree/main/Metro/
produces a zip file that contains a Metro
folder that then contains all of the files.
However https://download-directory.github.io/?url=https://github.com/AikoMidori/SteamSkins/tree/main/Metro/Metro-JS/
produces a zip file that contains Metro/Metro-JS
Also the same behavior applies to the repo you linked, with https://download-directory.github.io/?url=https%3A%2F%2Fgithub.com%2Frefined-github%2Frefined-github%2Ftree%2Fmain%2Fsource%2Fgithub-events/
containing source/github-events/*files*
from download-directory.github.io.
Related Issues (20)
- CRLF in files are being converted to LF only HOT 5
- Add MIT License file HOT 4
- Action Required: Fix Renovate Configuration HOT 1
- Token through query param is deprecated HOT 5
- What is the token? HOT 1
- Doesn't work for branches with slashes HOT 1
- Silently fails if token is missing HOT 5
- GitHub API format update HOT 1
- "No files to download" on large repos HOT 5
- Git LFS support HOT 1
- Can we re-use your code for our open-source community? HOT 3
- Failed to Load Resource: ERR_INSUFFICIENT_RESOURCES HOT 1
- Redirect to native zip URL when pasting a link to a branch, commit or tag
- Console errors on load
- Dependency Dashboard
- Getting error "Some files were blocked from downloading, try to disable any ad blockers and refresh the page." HOT 6
- RangeError: offset is out of bounds HOT 3
- Cannot download when filename contains hash (#) HOT 3
- File System Access API support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from download-directory.github.io.