Comments (13)
@utilForever volunteered to work on this issue!
@utilForever, currently dev-v2-gpu
is the main dev branch for the v2 release. This contains new C++ APIs (such as new vector/matrix implementations) so it would be great to start from there. You can branch out from dev-v2-gpu
and create something like dev-v2-gpu-pep8
, make changes, and raise PR against dev-v2-gpu
(not the master
of course).
from fluid-engine-dev.
@doyubkim Alright. I'll start working today.
from fluid-engine-dev.
@utilForever Also checking in to see where we're at on this. Thanks again for taking this effort!
from fluid-engine-dev.
@doyubkim Thanks. I'll work on this weekend. Please understand that my health is not very good.
from fluid-engine-dev.
Same as the other issue: @utilForever I am terribly sorry to hear that :( You should take a good break and not look at any codes. I will take this issue and raise a PR. Please take a good rest and get well soon!
from fluid-engine-dev.
Same as the other issue: @doyubkim Thanks. I'm OK now. So, please take this issue to me. 😄
from fluid-engine-dev.
@utilForever I am currently working on unifying redundant 2-D and 3-D codes and this will introduce quite a lot of changes in the Python binding lib. If you haven't started working on this issue, I recommend not starting it until the unifying work is completed.
from fluid-engine-dev.
@doyubkim I'm already working on this issue. I'll consider your unifying work. 🎉
from fluid-engine-dev.
@utilForever the latest dev branch is now merged into the dev-v2-gpu
branch. This contains some breaking changes in Python APIs so you may need to adapt to it. What's the latest status of this PEP8 work?
from fluid-engine-dev.
@doyubkim I'm now finished with exception of some grids. However, I'm working on changing the structure from 3 days ago.
from fluid-engine-dev.
@utilForever thanks for the update!
from fluid-engine-dev.
@doyubkim Update: My work is almost finished. Can I do a pull request to dev-v2-gpu
branch?
from fluid-engine-dev.
Thanks for the update! Yes, that should be the target branch.
from fluid-engine-dev.
Related Issues (20)
- How do I run the examples and the animations?
- How to run the particles2obj example? HOT 14
- Compile error when compiling with Clang 10 HOT 1
- Promotion of projects/research using Jet Framework HOT 4
- How to implement the xyz to mesh generation to another code for fluid simulation? HOT 1
- How do I set up a fluid particles at rest and a fluid particles with initial velocity HOT 3
- Suggestion to replace Travis CI/Appveyor with GitHub Actions HOT 5
- Some unit tests failure on 32-bit system
- Fix Visual Studio 2017 build failure on GitHub Action
- Timer test code failure on MinGW system
- No known features for CXX compiler "Clang" HOT 5
- running the Python example show error HOT 8
- Replace Clara
- makeTranslationMatrix should be transposed HOT 8
- About the local method in the surface_to_implicit HOT 1
- GridSmokeSolver3::computeDiffusion is diffusing smokeDensity instead of temperature HOT 2
- Incorrect formula for collider boundary conditions (Equation 3.18 in the book)
- can't build cmake in win64 HOT 1
- bug in void Matrix<T, M, N>::invert() in "include/detail/matrix-inl.h" HOT 1
- Newer Versions of Flatbuffer is breaking the build in particle_system_data2.cpp HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluid-engine-dev.