GithubHelp home page GithubHelp logo

Comments (3)

doyubkim avatar doyubkim commented on September 26, 2024

@aneeshvaidya, thanks for reporting this. It could be a test issue if I see other APIC test results which show low dissipation. Let me take a look.

from fluid-engine-dev.

aneeshvaidya avatar aneeshvaidya commented on September 26, 2024

In the Apic Solver 2d rotation test, I commented out the following line:

solver->setPressureSolver(nullptr);

And there was significantly reduced dissipation. Not sure what this means, but I think it may have to do with the pressure projection correcting the velocities, allowing momentum conservation?

from fluid-engine-dev.

doyubkim avatar doyubkim commented on September 26, 2024

@aneeshvaidya, you're right. So the intention of that piece of code was to eliminate everything else except APIC transfer (grid <-> particles) and put position constraint (line 91 to 95 of apic_solver2_tests.cpp) to apply rigid body constraint. That position constraint part can cause a projection error, and as you observed, solving pressure step will make the particles to stay in the circular course and thus less projection error. Let me remove that line.

from fluid-engine-dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.