Comments (4)
Before implementing the slug, I'd like to make sure we have a common understanding of what we want to achieve. The idea (at least mine) of using names instead of IDs for filenames and URL slugs was to make those easy to recognise and memorable. IMO the example slugs added in 4ba1157 tend to deviate from that idea. Some of them are way too long to be memorable and it takes quite some visual parsing to distinguish the different farces nouvelles from each other. I think we should stick to shorter slugs, also considering that they would end up as file names where an excessive length would be rather impractical for various reasons.
Also, underscores in the original filenames are already replaced by dashes when adding the files to fredracor, so slug overrides like anonyme-adam
or most of the racine-*
ones wouldn't actually be necessary.
from fredracor.
All very good points, and I agree we should put purpose first. So we might abandon the slug idea in general. Or, inherit the filename from TC, lowercase and dash it as we already do, but additionally divide words in our slugs.
E.g. "anonyme-resurrectionjeninlandore" → "anonyme-resurrection-jenin-landore"
If we'd be a commercial website, I'd argue that we do this for SEO reasons.
So, if we decide to do it this way, should we strive for an automatic solution that uses the title pattern to divide slugs, or manually?
from fredracor.
I just committed the compromise proposed above (28edf10).
Slugs now feature the exact same letters as in the original TC, but individual words are separated with dashes (both authors and abbreviated titles). I kept the underscore between author(s) and titles, in case we need it later. Other than that, underscores can still be transformed to dashes in the URL.
Examples:
- "LAFONTLESAGE_QUERELLEDESTHEATRES.xml" → "lafont-lesage_querelle-des-theatres.xml"
I did not remove obvious spelling mistakes (there are just a few), like this:
- "DIDEROT_ENTRETIENDELAMBERTDIDEROT.xml" → "diderot_entretien-d-elambert-diderot.xml" (should be "d'alembert")
from fredracor.
@lehkost please have a look at the above PR. I replaced all underscores with hyphens for simplicity. I also removed all slug
attributes that are not strictly necessary because they affect the performance of the transformation script. I also updated the staging database with the new versions.
from fredracor.
Related Issues (11)
- Add classCode elements for matching genre information
- Lookup Function ISNI to Wikidata HOT 2
- Upper/lower case problem with character names
- Optimize matching of castItems to particDesc HOT 1
- Make all documents comply to the TEI-all schema
- Rewrite instances of tei:ab[@type="stances"] to tei:lg
- wikipediaLinkCount always "0" for FreDraCor HOT 1
- unresolved pair characters with 'et' in many French plays HOT 2
- Fix print dates
- Document ids.xml workflow
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fredracor.