Comments (5)
It seems you are right !
@damassi what do you think ?
Unfortunately, I have no time right now to test this, maybe tomorrow !
from styled-bootstrap-grid.
Hi @tomhonig - It should be props.theme.grid.breakpoints
, as seen in our theme here: https://github.com/artsy/palette/blob/master/src/Theme.tsx#L94-L99.
I think the issue you might be seeing is a bug related to the media
helper. On our end we use our own custom one: https://github.com/artsy/palette/blob/master/src/helpers/media.ts
from styled-bootstrap-grid.
I'm on my phone, in a bus. I'll explain with more details later if you need it.
As far as I can see on my tiny screen, I think that you are right @tomhonig. We should read the styledBootstrapGrid
object instead of the grid
one.
The reason why the props.theme.grid
object works in @damassi case is because, at the end, the props.theme
object is shared between the ThemeProvider
and the GridThemeProvider
.
I will experience this tonight (or tomorrow) and I'll come back with more answers.
I confess, I don't need to use custom breakpoints on my different projects. :$
from styled-bootstrap-grid.
@dragma - one thing that I think would simplify this grid approach is removing the GridThemeProvider component completely. Its not needed since one has access to the styled-components theme provider, and the settings set there are accessible from within the lib. I keep meaning to PR this change back, but it would be a major version breaking change. It would simplify things considerably though.
from styled-bootstrap-grid.
Thank you for your replies!
Using ThemeProvider
instead of the GridThemeProvider
solved it:)
from styled-bootstrap-grid.
Related Issues (20)
- React 17.0.x compatibility
- Theme Provider has a delay generating css
- Support Styled Components V6 HOT 1
- Column Width issue HOT 19
- Container Fluid max-width HOT 2
- Media min and max HOT 2
- GridThemeProvider needs children prop HOT 1
- npm install error v3.0.3 HOT 8
- Customize the amount of columns HOT 2
- Breakpoint sensitive paddings HOT 2
- Flex direction support
- Git submodule HOT 1
- Usage of !important for components styling causes error on AMP pages. HOT 10
- hidden{bp}Up media query misses 1px math HOT 5
- Col offset breaks other breakpoints
- Feature request: lessThan media type HOT 2
- Adding extra breakpoints trough gridThemeProvider HOT 1
- Changelog for breaking changes?
- Request: Number of columns prop for Row HOT 1
- Custom css appends a class over current css
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from styled-bootstrap-grid.