GithubHelp home page GithubHelp logo

Comments (3)

drahnr avatar drahnr commented on August 27, 2024 1

It is! It actually breaks a few baked in assumptions that changes are atomic and non-overlapping. So the second one can mess up the text after the first got applied with a different character span. Note that the languagetool got replace by nlprules backend, and the priority is more on the correctness of applying changes.
Stage 2 would be, to re-reparse comments that had overlapping fixes, but that's not really in the scope of 🔰 anymore.

I'd recommend to take a look at the structure how it works, do a first draft PR, might be just comments!, where you think the changes should go and we can continue the discussion from there :)

from cargo-spellcheck.

drahnr avatar drahnr commented on August 27, 2024

In the hindsight, it's probably a non trivial issue to disambiguate (smells like coverage problem on spans).

The 🔰 part is to detect overlaps and discard the secondary, but do another cycle of checking with the provided checkers.

from cargo-spellcheck.

granddaifuku avatar granddaifuku commented on August 27, 2024

@drahnr
If this is still the issue, can I work on the 🔰 part of this at a minimum?
Thanks

from cargo-spellcheck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.