Comments (3)
It is! It actually breaks a few baked in assumptions that changes are atomic and non-overlapping. So the second one can mess up the text after the first got applied with a different character span. Note that the languagetool
got replace by nlprules
backend, and the priority is more on the correctness of applying changes.
Stage 2 would be, to re-reparse comments that had overlapping fixes, but that's not really in the scope of 🔰 anymore.
I'd recommend to take a look at the structure how it works, do a first draft PR, might be just comments!, where you think the changes should go and we can continue the discussion from there :)
from cargo-spellcheck.
In the hindsight, it's probably a non trivial issue to disambiguate (smells like coverage problem on spans).
The 🔰 part is to detect overlaps and discard the secondary, but do another cycle of checking with the provided checkers.
from cargo-spellcheck.
@drahnr
If this is still the issue, can I work on the 🔰 part of this at a minimum?
Thanks
from cargo-spellcheck.
Related Issues (20)
- reflow sub command transposes `//` and leading space HOT 7
- Panic hunspell returned non-utf8 sequence HOT 7
- hunspell stumbles over copyright symbol HOT 5
- Broader CI/Docker usage support HOT 6
- How to ignore files HOT 7
- Build failure due to clang HOT 6
- How to add words? HOT 2
- Is there way to skip over doc links in comments? HOT 2
- Interactive fixing seems buggy HOT 3
- Support cargo-binstall HOT 9
- Reduce release artefact download size HOT 2
- Spellcheck doesn't list files when edition is inherited HOT 3
- Adding a footnote gives false positives HOT 2
- Is there a way to ignore commented out code? HOT 2
- Help identifying panic: `assertion failed: plain_range.start <= plain_range.end` HOT 15
- Non determinism with hunspell backend HOT 1
- Installing the crate in a macbook machine HOT 8
- Don't flag valid identifiers as misspelled in doc comments HOT 1
- Handle Snake_Case: Treat Underscore (and Hyphen) as white space HOT 6
- Use directives of "Code Spell Checker" for Visual Code HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-spellcheck.