Any app (incl. default example) crashes with "Can't find variable: React" when launched from a JS bundle on an iOS device about re-natal

[drapanjanas]

Hi, thanks for reporting. Reproduced it on iOS and Android using reagent and on-next interfaces
Actually to reproduce I just had to do:

$ re-natal init CrashingApp
$ cd crashing-app
$ react-native run-ios

I am almost sure I check the steps above before each release, but now surprise, this does not work! Latest changes in re-natal were only in figwheel-bridge.js which is not used at all in case of 'lein prod-build'.

But, I could find still working version of luno-react-native app on my local drive (tar.gz is too big to upload here) I have uploaded it to temp storage in the internets: luno-react-native.tar.gz
To successfully run it:

$ tar xvzf luno-react-native.tar.gz
$ cd luno-react-native
$ lein prod-build
$ react-native run-ios

To reproduce the problem:

$ rm -rf node_modules
$ re-natal deps
$ react-native run-ios

This makes me think tat recent NPM cleanup has sometheing to to with this

[drapanjanas]

OK, I am confused, but seems I have found the solution.The problems seems to be with the global variable assignment:

(set! js/React (js/require "react-native"))

which compiles into (which is expected):

React=require("react-native");

But, I guess that now some kind of validation is in place to forbid global assigments like that, huh?

So, the solution/workaround is:

(set! js/window.React (js/require "react-native"))

Instead of window variable GLOBAL also works (which points to window I think)

@gnl can you check and confirm that this workaround works also for you?

[gnl]

Fix confirmed, thank you!