h#url_for within decorators is broken about draper

[jcasimir]

Julien,

Interesting, I don't have an easy answer for you. I'll try some experiments and see if anyone comes up with a suggestion/solution in the meantime.

[jperville]

Hello,

I finally decided to hide my initialization code in spec_helper.rb.

# Used to initialize decorator specs. Called from a 'before' block.
def initialize_controller_view_context_for_draper
  c = ApplicationController.new
  c.request = ActionDispatch::TestRequest.new
  c.set_current_view_context
end

Then I use in each spec that renders a view in the before hook:

describe UserDecorator do
  before { initialize_controller_view_context_for_draper }
end

This is now manageable but still not very satisfying.
I will keep watching this thread.

Thank you very much.

Julien

[voldy]

Hello,
I faced with the same problem when tried to spec url_for.

@jperville: thank you for your solution. I have modified it a little and placed to spec_helper.rb:

module Draper::ViewContextFilter
  alias :original_set_current_view_context :set_current_view_context

  def set_current_view_context
    controller = ApplicationController.new
    controller.request = ActionDispatch::TestRequest.new
    controller.original_set_current_view_context
  end
end

Then it is possible to use Draper's standard call:

before { ApplicationController.new.set_current_view_context }

[andreacfm]

Hi I am using @jperville workaround.
Will this be fixed or does exists a better way?

[tooky]

Using the workaround makes url helpers work within the decorator, but you can't reference the helpers within the spec!

[jcasimir]

Working on this...

[henrik]

@tooky To reference the helpers within the spec, do e.g.

describe SomeDecorator, "#foo" do
  include Rails.application.routes.url_helpers
  it { blah.should == root_path }
end

[tooky]

@henrik thanks! I think I must have had this in and removed it for some reason when adding the workaround!

[steveklabnik]

So! This issue is fixed. Actually. Here's the solution:

1. If you have before { ApplicationController.new.set_current_view_context } in your spec, delete it. Older versions of Draper generated this line, but no longer.
2. Update your copy of Draper. 58e9893 introduced stubbing out the request properly. It's in both 0.12.1 and 0.13.0.

This fixed it on my test application, so I'm closing. If it doesn't on yours, well........ that's bad. We can re-open and figure it out.

[jperville]

Thank you so much for fixing the issue.
Julien

[steveklabnik]

No problem. @cheald did all the work. ;)