GithubHelp home page GithubHelp logo

Comments (4)

tmaier avatar tmaier commented on July 20, 2024

It seems like this bug is not related to nested_form. It's related to ActionView.

When using draper, fields_for does not set the :child_index (as called by nested_form in line 25).

FormHelper uses and sets the child_index in https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/form_helper.rb#L1398-1415

I added some debug calls for the method fields_for_with_nested_attributes and this is the result:

start fields_for_with_nested_attributes for new_phones
  respnds to persisted
    before line 1403: #<Phone:0x000001026e9120>
    after line 1403:  #<Phone:0x000001026e9120>
  respond_to?(:to_ary)
    nay!
start fields_for_with_nested_attributes for new_emails
  respnds to persisted
    before line 1403: #<Email:0x00000102539ac8>
    after line 1403:  [#<Email _id: 4ede6477499dda1d14000006, _type: nil, type: "Work", email: nil, status: nil>]
  respond_to?(:to_ary)
    yay!

phones and emails have exactly the same relation (mongoid, embeds_many), but to different Models. phones uses PhoneDecorator and emails Email.

This means the call to

association = [association] if @object.send(association_name).is_a?(Array)

in line 1403 fails.

from draper.

steveklabnik avatar steveklabnik commented on July 20, 2024

Is this still an issue now that that pull request has been merged in?

from draper.

tmaier avatar tmaier commented on July 20, 2024

No. Thanks for merging!

from draper.

steveklabnik avatar steveklabnik commented on July 20, 2024

w00t!

from draper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.