GithubHelp home page GithubHelp logo

Comments (3)

sreyan-ghosh avatar sreyan-ghosh commented on May 30, 2024 1

Aah I see, so boto3_kwargs is like a super wrapper for boto3.client and boto3.resource. No worries, it's all a learning experience for me. Thanks for the descriptive answer @DrGFreeman 😄

from dynamo-pandas.

sreyan-ghosh avatar sreyan-ghosh commented on May 30, 2024

Hi @DrGFreeman, so first 2 changes need to be made in the dynamo_pandas/dynamo_pandas.py file.

These functions need to have **kwargs added, so as per your example, should all of them have **resource_kwargs added or **client_kwargs also?

Would the following be correct?

  • get_df
def get_df(*, table, keys=None, attributes=None, dtype=None, **resource_kwargs):
    """Get items from a table into a dataframe."""
  • put_df
def put_df(df, *, table, **resource_kwargs):
    """Put rows of a dataframe as items into a table. If the item(s) do not exist in the"""

from dynamo-pandas.

DrGFreeman avatar DrGFreeman commented on May 30, 2024

Hi @sreyan-ghosh, thanks for your interest! For you info, I have already started working on this. I just assigned myself the issue to avoid confusion.

Regarding your question, I've settled to use a boto3_kwargs parameter to all the functions where it is applicable. Since both the boto3.client() and boto3.resource() function calls share the same parameters, this will leave the possibility to refactor the functions and change between boto3.client and boto3.resource internally without affecting existing code making use of the boto3_kwargs parameter.

from dynamo-pandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.