Comments (4)
Applying the patch as is might interfere with mod_fcgid. Please recheck that this doesn't give any problems with duplicate symbols across modules. There have been such issues before causing hard-to-find crashes.
Otherwise the patch looks sane, although providing a custom callback for old versions (#define apr_shm_remove our_apr_shm_remove) might be the better option in this case.
from apache-upload-progress-module.
I forgot to add, that's the mail that I got and I wanted to have it here, so maybe someone else can investigate that.
I also don't think that applying that patch as is will work. If you have the time and you want to check it, that would be great. I like the idea of defining custom callback for older versions.
from apache-upload-progress-module.
Well, the "AS IS" was not ment literally, but on a "no changes to the patch code except for integration". I'll have a look into integrating it, but I won't be able to test it. I'll report back here as soon as I have a commit integrating it.
I just pushed a patch in commit e8a9850. Please test and report back.
from apache-upload-progress-module.
The commit containing the backport of the mentioned patch has been pulled in.
from apache-upload-progress-module.
Related Issues (20)
- Unreachable Code in Shared Memory handling HOT 3
- Commit 568e breaks functionality HOT 2
- Handling load balanced server calls HOT 4
- Constraints for valid Progress-IDs HOT 11
- Location block in global context is ignored HOT 1
- Makefile conflicts with dpkgbuildpackage HOT 1
- Progress bar appeares only at %100 for 2-3 seconds HOT 26
- Tag a new release of the module
- Small uploads stuck at 'starting' HOT 1
- invalid content type header
- canceled uploads return 'success' status
- upload never 'done' HOT 3
- received == size immediately, yet it takes a few seconds to be 'done' HOT 4
- Upload Timeout Problem HOT 2
- Problem Compiling with xcode4/OSX
- Any plans for an nginx module? HOT 1
- Daily apache log rotation crashes when trying to reload apache
- Missing required architecture ppc64 in file HOT 1
- Only getting the size HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apache-upload-progress-module.