GithubHelp home page GithubHelp logo

Comments (4)

BenBE avatar BenBE commented on September 28, 2024

Applying the patch as is might interfere with mod_fcgid. Please recheck that this doesn't give any problems with duplicate symbols across modules. There have been such issues before causing hard-to-find crashes.

Otherwise the patch looks sane, although providing a custom callback for old versions (#define apr_shm_remove our_apr_shm_remove) might be the better option in this case.

from apache-upload-progress-module.

drogus avatar drogus commented on September 28, 2024

I forgot to add, that's the mail that I got and I wanted to have it here, so maybe someone else can investigate that.

I also don't think that applying that patch as is will work. If you have the time and you want to check it, that would be great. I like the idea of defining custom callback for older versions.

from apache-upload-progress-module.

BenBE avatar BenBE commented on September 28, 2024

Well, the "AS IS" was not ment literally, but on a "no changes to the patch code except for integration". I'll have a look into integrating it, but I won't be able to test it. I'll report back here as soon as I have a commit integrating it.

I just pushed a patch in commit e8a9850. Please test and report back.

from apache-upload-progress-module.

BenBE avatar BenBE commented on September 28, 2024

The commit containing the backport of the mentioned patch has been pulled in.

from apache-upload-progress-module.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.