GithubHelp home page GithubHelp logo

inconsistent licence about clj-oauth HOT 8 CLOSED

drone-rites avatar drone-rites commented on August 22, 2024
inconsistent licence

from clj-oauth.

Comments (8)

drone29a avatar drone29a commented on August 22, 2024 1

Yes, simplified BSD. Will update project file, thanks!

from clj-oauth.

fommil avatar fommil commented on August 22, 2024

the reason I ask is because I don't want the dependency on clj-http so I'm taking just the bits I need. I've been told that https://github.com/jcf/oauth/ will be the future, if you're not already it would be great if you could pool your resources and perhaps turn it into clj-oauth v2.

from clj-oauth.

drone29a avatar drone29a commented on August 22, 2024

There's no reason for a dependency on clj-http. That was a requirement for a project this library was written for, but it should be changed. The clj-oauth functions should just return the params and headers for requests and let the user choose their own HTTP client. It looks like jcf's oauth is doing something similar to that. Out of curiosity, why use clj-oauth instead of jcf's oauth?

If you do end up updating clj-oauth to remove the clj-http dependency, I'll gladly accept a pull request.

from clj-oauth.

fommil avatar fommil commented on August 22, 2024

I don't think I can remove clj-http without breaking your API but if you're OK doing that I might be able to put something together.

jcf's repo is very new and is "not yet released" according to the notes. Maybe something for the future.

from clj-oauth.

drone29a avatar drone29a commented on August 22, 2024

Yes, I think the API will have to change, and that's OK. We'll make it a major version bump.

It may be possible to also provide "authentication workflow" function(s) which would require the user to provide functions for making and parsing HTTP requests and responses. This would help prevent the user from dealing directly with the OAuth workflow.

from clj-oauth.

fommil avatar fommil commented on August 22, 2024

it's unlikely that I'll get round to this because I've just given myself the weekend to learn clojure and then I'm back to some pretty big commitments in Scala land (plus my wife has just informed me that the laptop has to go away 😊 )

from clj-oauth.

drone29a avatar drone29a commented on August 22, 2024

Hah, no worries, it's something that's needed to be done for awhile. But with jcf's oauth lib, maybe it's time to deprecate clj-oauth in the near future.

Fixed the license mismatch in project.clj. Feel free to open up another issue if anything else comes up or you want to tinker with the clj-http removal.

from clj-oauth.

fommil avatar fommil commented on August 22, 2024

I think it would be best if jcf's library becomes clj-oauth v2 actually, I really hate to see fragmentation.

from clj-oauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.