Comments (6)
I'm going to disable the canary in the test case by default, since it doesn't look like the standards committee is going to address this anytime soon. It seems more important that new users of the library can make test
and run successfully the first time without being confused.
from json11.
Core issue 2137 was resolved by P0384R0 back in June 2016. The core issues list is just (very) slow to update.
from json11.
@timsong-cpp thanks for the update. I'm not familiar enough with terminology of the standard or the operations of the committee to be sure what that document is saying. Can you provide any color? There's a "proposed resolution" from April in a doc of "tentatively ready" issues from June. Does that mean the proposed resolution was was accepted? What does the proposed text actually mean for the example?
I'm hopeful that this might actually be a useful resolution, in which case we then only need to wait for compilers to implement the change.
from json11.
There's a "proposed resolution" from April in a doc of "tentatively ready" issues from June. Does that mean the proposed resolution was was accepted?
It was accepted. (The core - and library - working group prepares lists of ready and tentatively ready issues for each meeting for adoption by the full committee. Almost all of the time they all get adopted - and this one was, but to be sure in the general case you'd need to check a few more places.)
What does the proposed text actually mean for the example?
It reverts the DR1467 change for non-aggregate class types. Those will get the previous behavior.
from json11.
Ah, I didn't realize that change was a revert of the previous one, and I just educated myself on the formal definition of aggregate class, so this sounds good for json11's needs. Looking forward to seeing it implemented. Thanks.
from json11.
I'm pretty sure the "right" language behavior is now in all the recent compiler versions, so I'm closing this issue out.
from json11.
Related Issues (20)
- is it possible to add fields to the json? HOT 1
- in json11.cpp line 161 , why use static_cast, what if a json object is a runtime parsed object HOT 1
- clang 6.0 compilation error HOT 2
- Check if a json object key exists HOT 2
- differentiate between "number" and "integer" as per json schema HOT 1
- Tag Versioning HOT 6
- Number size issue.
- Can't parse wstring?
- auto casting HOT 4
- has_shape() always returns true when used with json11::Json::NUL HOT 1
- [Feature] conan package manager support HOT 1
- Order serealization Json::object HOT 2
- ASAN reports runtime error HOT 1
- swig4.0.0 and mingw compile the test.cpp(main modified to be a function) :error: 'final' is not a member of 'json11' HOT 3
- can't be loaded as a dll in low version c++? HOT 2
- Warning '-Werror=overloaded-virtual' with gcc-5.1.0 --std=c++14 HOT 1
- Making object_items(), array_items() not const or alternatively support mutable_object_items() HOT 1
- Super stuff. HOT 1
- No API to add Json (f.e. array) to Json::object outside of ctor. HOT 1
- Buliding for windows? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json11.