GithubHelp home page GithubHelp logo

Comments (5)

tomsommer avatar tomsommer commented on July 21, 2024

+1 Please fix this

from zxcvbn.

lowe avatar lowe commented on July 21, 2024

I did this on purpose to make it as easy as possible to set up zxcvbn, as well as allow people to download the bulk from Dropbox's CDN.

That said, I've seen enough confusion that I don't mind changing.

from zxcvbn.

tomsommer avatar tomsommer commented on July 21, 2024

Thanks. Could you recompile the coffee too? Or what is the procedure for the .js files?

from zxcvbn.

tomsommer avatar tomsommer commented on July 21, 2024

There is an issue with the change.

If zxcvbn.js is stored in /bower_components/zxcvbn/zxcvbn.js the call from /bower_components/zxcvbn/zxcvbn-async.js with src = 'zxcvbn.js' will call '/zxcvbn.js', resulting in a 404

I'm not entirely sure how to fix this without requiring people to edit the -async.js file, which sort of defeats the purpose of bower.

from zxcvbn.

lowe avatar lowe commented on July 21, 2024

Hey @tomsommer, I added a separate zxcvbn-async-bower.js file for bower setup with instructions in the README, it should just work now.

from zxcvbn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.