GithubHelp home page GithubHelp logo

Comments (3)

the-simian avatar the-simian commented on May 23, 2024

How about fileName.replaceAll("[\\\\/:*?\"<>|]", "") This actually just targets the illegal characters, so it works subtractively rather than only allowing the chars here. It would allow spaces but also disallow certain characters. Is this too permissive?

the fix to keep the existing pattern would be:
filename.replaceAll("/[^a-zA-Z0-9 ]/", ""). Looks similar but there's a space after the 9, but that wouldn't trim leading and trailing spaces, so I think Java has a .trim() method for that? so like:
filename.replaceAll("/[^a-zA-Z0-9 ]/", "").trim()

As for repeated spaces... I know it would be slick to do it all in one regex but if we added .replaceAll("\\s+"," ") to the end that would remove any runs of more than one space, too.

Not 100% sure how to write that all as a single regex, but
return filename.replaceAll("/[^a-zA-Z0-9 ]/", "").trim().replaceAll("\\s+"," ");
...i think would be ok

from owlplug.

DropSnorz avatar DropSnorz commented on May 23, 2024

Thank you for your suggestions. I've updated the function to allow spaces in filenames.
I've also added a few unit tests to ensure the behaviour is correct.

from owlplug.

DropSnorz avatar DropSnorz commented on May 23, 2024

Fix released in OwlPlug 0.15.0

from owlplug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.