GithubHelp home page GithubHelp logo

Comments (6)

mghosh4 avatar mghosh4 commented on July 21, 2024

Using the curl based client will put 2 additional dependencies. You need to install libcurl4-openssl-dev in linux and also pycurl python package. Should I just change the doc for this? Or is there a way to add this dependency in the patch?

from pydruid.

turu avatar turu commented on July 21, 2024

Are you sure it doesn't work? I'm asking because it does work on production since many months in our stack. You may want to take a look at this: http://www.tornadoweb.org/en/stable/httpclient.html#tornado.httpclient.AsyncHTTPClient ;)

from pydruid.

mghosh4 avatar mghosh4 commented on July 21, 2024

I see. I might be using the constructor wrong then. From what I understand if I configure AsyncHTTPClient to use the correct class. It should work? Let me know if I do not understand this.

from pydruid.

turu avatar turu commented on July 21, 2024

@mghosh4 You just need to use the constructor as described in the linked docs. The simple_httpclient is fully sufficient and definitely should stay as the default, since it doesn't require any additional dependencies installed on your machine - unlike the curl_httpclient.

Perhaps, a patch allowing people to override the default client could be useful though. Feel free to submit one.

from pydruid.

turu avatar turu commented on July 21, 2024

@gianm @xvrl @fjy
I would suggest closing this issue, since its name may be misleading people to think that the async client is broken - It isn't.

from pydruid.

fjy avatar fjy commented on July 21, 2024

Thanks @turu

from pydruid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.