Comments (12)
Awesome work! All looks good now; I updated an anime library entry successfully.
Logs attached for reference if you'd like to review:
Kitsune_2023-10-01_15-02-13.txt
from kitsune.
Fix got released in v1.8.1.
Thanks for your help!
from kitsune.
Sorry, I have deleted your comment as a precaution, because possibly sinsible user data could be logged in the debug logs.
from kitsune.
Kitsune_2023-09-30_23-08-54.txt
from kitsune.
Thanks for providing the logs. It is really strange that the server returns a 400 HTTP code. That would basically mean that the library update request was somehow malformed. Haven't seen that before yet.
It would be helpful if you could give me some more context, such as steps to reproduce.
But since I have completely refactored the library management in the latest update, it's quite possible that the bug no longer exists in v1.8.0. Therefore, please update to the latest version and if you encounter any errors again, feel free to respond to this issue or open a new one.
from kitsune.
Thanks for taking a look. I have updated to v1.8.0 but unfortunately still has issues updating the library. The new error now shows in the GUI as "Failed to update library entry". The same error happens on WiFi or mobile data. I've checked DNS logs while on WiFi and there are no blocked entries that would like up with the testing (I run AdGuard Home for DNS ad blocking). Android Private DNS was disabled for mobile data testing, so no DNS filtering.
My device I'm using is a Google Pixel Fold, running the Android 14 QPR Beta 1 build U1B1.230908.003 (probably a huge factor).
I've made a screen recording on reproducing the error from a clean install (stored on OneDrive): https://1drv.ms/v/s!Akc_qyFJBJTajJAbAnoAzGKbAD-FsA
Here are the logs from the testing:
Kitsune_2023-10-01_07-40-48.txt
Please let me know if you need any additional information.
from kitsune.
Thanks for the detailed information. Unfortunately I cannot reproduce the error on my device.
Could you please try the same thing with the debug build below and send the logs again. The debug build will also log the network requests and should give a bit more insight into what is going on.
Here's the debug build: https://workupload.com/file/MMqVJ2Svf78
Small hint: The debug build has the same name as the release version. So don't be confused if suddenly two Kitsune apps appear on your home screen.
from kitsune.
The previous debug build logged all HTTP requests including the authentication request, which contained sensitive credentials. That's now fixed and there shouldn't be any sensitive user data in the logs now.
Here's the fixed build: https://workupload.com/file/v7k7vu6pHC4
from kitsune.
Thanks for looking out. I've installed the newest debug build and reproduced the error. Please find the logs below.
Kitsune_2023-10-01_09-52-08.txt
Edit: I've also rotated my password to err on the side of caution.
from kitsune.
Thanks a lot! I have found the source of the problem. Somehow a parameter "stability" is sent in the library update request, which should not be there.
Request body:
{"data":{"type":"libraryEntries","id":"123456","attributes":{"progress":4,"stability":0}}}
Response body:
"errors":[{"title":"Param not allowed","detail":"stability is not allowed.","code":"105","status":"400"}]}
I will look into that and try to track down where the paramter is coming from.
from kitsune.
Thanks for the update! Great you were able to find the source of the issue.
from kitsune.
Wow, it took longer than I thought to track down this odd "stability" property. But the bug should be fixed now.
Could you test the build below to verify. If everything is working now, I will release a hot-fix tomorrow.
Fixed build: https://workupload.com/file/kmhsF9nT3y8
from kitsune.
Related Issues (20)
- Started date is not set when starting watching a new anime
- Refresh access token on 401 response code
- OLED Black Theme? HOT 2
- Dynamic theme is not set in DialogFragments
- Fix themed app icon
- Movies are not set to finished
- Statusbar scrim is not set when resuming library fragment
- Character Details
- Allow to edit profile links
- Why not upload to Play store and F-droid? HOT 4
- SearchView in library fragment is not shown
- Improve UX in filter facet fragment
- Add check for update in parentheses next to app version!! HOT 5
- Allow choosing own server. HOT 6
- Add Average User Rating to TV/Movie pages HOT 5
- Change labels on the library page when Manga is selected HOT 1
- Adding french language HOT 1
- App crashes when opening 'Characters' page HOT 1
- Not able to login HOT 4
- Add on-boarding on first launch
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kitsune.