[Feature] Support custom `git diff` options about patch-package

[alexandrospanagiotidis]

Just tried it, works perfectly for me 👍

[ds300]

Great idea, thanks! I think I'll do this tonight.

[ds300]

Can you see any downside to ignoring EOL whitespace differences by default?

[alexandrospanagiotidis]

Not really, probably best to do so.

[ds300]

Yeah me neither. I'll do that first and then think about how to support other git diff options later. I think just allowing arbitrary commands through would be the wrong thing to do. Most of them are unrelated to patch-package's concerns.

[ds300]

I've done this and it's in master, but haven't been able to publish. npm registry seems to be failing. Will try again tomorrow.

[alexandrospanagiotidis]

Yeah, I thought arbitrary options would help working around future issues but you are right that most of them won't be needed.
Thanks for fixing the issue and keep up the good work!

[ds300]

Oh, looks like it did get published last night and the npm registry was just being unresponsive somehow. Try out version 3.5.1!

[ds300]

Had some time to look at the git diff docs, and there are three options I could imagine being useful to me one day, and maybe another five that might fit some very particular use cases I can't foresee. Anyway, I think I'll do what you originally suggested and make it so that any args passed after a solitary -- are then passed to git diff when creating patches. This is the lazy way out.

e.g.

patch-package my-package -- --diff-algorithm=patience

[alexandrospanagiotidis]

While I appreciate this, I did not have a closer look at all options, so I suggest adding some kind of warning because some options might interfere with the normal usage of patch-package ;)

[wardpeet]

:o I was looking for this :D I had to do -- --no-color any chance this can be added the the README? I could create a PR for it

[ds300]

I think I'm misunderstanding your comment. Are you saying that it worked for you when adding -- --no-color?

This feature isn't implemented yet, so that would be odd 👀

[wardpeet]

Sorry, I had to add --no-color in the code to make this work so it would be nice to have this feature. Do you need help implementing?

[ds300]

@wardpeet Yeah that'd be great if you've got the time!

[KevinVlaanderen]

Normally, a double dash signifies the end of the argument list. Any arguments you pass afterwards are generally passed to the root command (e.g. npx / node) [https://linux.die.net/man/1/bash].

"A -- signals the end of options and disables further option processing. Any arguments after the -- are treated as filenames and arguments. An argument of - is equivalent to --. "

Passing these arguments to git instead could be fairly confusing. Maybe it's better to copy npx' approach, e.g. add a --git-arg parameter? [https://www.npmjs.com/package/npx]

"-n, --node-arg - Extra node argument to supply to node when binary is a node script. You can supply this option multiple times to add more arguments."

[ds300]

Closing this issue due to inactivity.