GithubHelp home page GithubHelp logo

fip-player's People

Contributors

atouminet avatar delthas avatar ducng avatar slashformotion avatar

Stargazers

avatar avatar avatar avatar avatar

Watchers

avatar

Forkers

jeanthom atouminet delthas

fip-player's Issues

Segfault after pausing from GNOME gui

Steps to reproduce:

  • Start any radio
  • Pause from gnome wigdet
panic: runtime error: invalid memory address or nil pointer dereference                                                     
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7104a3]

goroutine 137 [running]:
github.com/DucNg/fip-player/dbus.(*MediaPlayer2).PlayPause(0xc000118fa0)
	/home/calvados/s/fip-player/dbus/mediaplayer2.go:66 +0x23
reflect.Value.call({0x7ed1e0?, 0xc000118fa0?, 0xb0ec40?}, {0x82d4a6, 0x4}, {0xb72e10, 0x0, 0xc00053aca0?})
	/usr/lib/go/src/reflect/value.go:586 +0xb0b
reflect.Value.Call({0x7ed1e0?, 0xc000118fa0?, 0x0?}, {0xb72e10?, 0xc000140ae0?, 0x17?})
	/usr/lib/go/src/reflect/value.go:370 +0xbc
github.com/godbus/dbus/v5.exportedMethod.Call({{0x7ed1e0?, 0xc000118fa0?, 0x0?}}, {0xb72e10, 0x0, 0xc0001a6000?})
	/home/calvados/go/pkg/mod/github.com/godbus/dbus/[email protected]/default_handler.go:128 +0x1f9
github.com/godbus/dbus/v5.(*Conn).handleCall(0xc0001a6000, 0xc000302ab0)
	/home/calvados/go/pkg/mod/github.com/godbus/dbus/[email protected]/export.go:193 +0x56d
created by github.com/godbus/dbus/v5.(*Conn).inWorker
	/home/calvados/go/pkg/mod/github.com/godbus/dbus/[email protected]/conn.go:435 +0x27b
exit status 2

Strange display when title bar is spread on multiple lines

When title bar is spread on multiple lines list is buggy because m.list.SetSize() doesn't have the right value anymore.

Way to fix this: detect when title is longer than available width and use ellipsis to avoid overflow (instead of line wrap)

Nice to have

List of things that could be implemented:

  • Album arts in mpris
  • Restore last played radio instead of the first item of the list
  • CI to build the app on push
  • Makefile to build and install the app
  • Currently playing radio indicator in the gui
  • Song progress bar in the gui
  • Song progress in mpris #20
  • Change metadata not on delayToRefresh but when song ends (like intended by the API) (seem to be buggy on official client as well)
  • Pause from gui
  • Pause indicator in GUI (change icon next to track name)
  • Mouse support

Duplicate entry in gui

In some cases, a radio entry will duplicate on the gui.

Input sequence to produce the bug (in vim notation):

/contemp<CR><CR><Esc>j<CR>/rock<CR>

Which shows

Screenshot from 2022-12-19 15-19-17

Unable to listen to La Contemporaine

Hello Sir,

I am unable to listen to La Contemporaine because of the following error:

➜  fip-player git:(master) go run main.go
# github.com/DucNg/fip-player/player
player/mpv.go:317:8: could not determine kind of name for C.MPV_EVENT_PAUSE
player/mpv.go:319:8: could not determine kind of name for C.MPV_EVENT_UNPAUSE

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.