GithubHelp home page GithubHelp logo

dulatr / worldtimeapi Goto Github PK

View Code? Open in Web Editor NEW
0.0 0.0 0.0 7 KB

A python wrapper for http://worldtimeapi.org/

License: MIT License

Python 100.00%
python-package python3 timezone world-time wrapper-api

worldtimeapi's People

Contributors

dulatr avatar

Watchers

 avatar  avatar  avatar

worldtimeapi's Issues

Addition of Docs/ static gh-pages

Docs

While not 100% necessary, having a Docs/ page will help this project visibility and usage. This could be considered for future package releases. I'd also like to ensure that edits are only made on the dev branch that follow changes to base version.

Payload argument for client.get() fails when missing specific keywords

Payload construction

Expected

When creating a payload for the request, if keywords are missing it should raise a KeyError. For example:

# Should throw an error saying 'area' is missing
payload = {"location":"...", "region"}

#Should throw an error saying 'location' missing
payload = {"area":"...", "region":"..."}

# 
myclient = client('timezone')
myclient.get(payload)

Observed

Currently, doing any of the example above returns and unknown location response from the server. I would like to avoid this ambiguity since they may have a correct keyword item for what they are passing, but missing an important argument will not clarify that point.

Unit Tests needed

Unit testing

Title explains it.

I would like to have some unit tests to reduce future hotfixes necessary for releases. #1 Could have been avoided if this had been introduced. Specifically, testing client responses from various payloads.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.