Version not set in Docker container? about transfer.sh

[aspacca]

hello @luckman212 , thanks for reporting this bug

the problem is that the build command on docker file does not work properly, with git describe --tags failing since it's run not inside a git repo

[luckman212]

Is there any workaround you could suggest? What about just hardcoding the current version in a VERSION file and having the Dockerfile read from that?

[stefanbenten]

You can use watchtower to achieve the same without having to write a script :)

[luckman212]

Ok I'll look into that, thanks

[amayer5125]

I believe the issue is that ".git" is in .dockerignore. When COPY . . is run, the files in .dockerignore are skipped. Since the .git directory isn't copied into the docker image the command that sets the version (git describe --tags) fails. Removing ".git" from .dockerignore fixes the issue for me.

$ docker run --rm transfer.sh version 
transfer.sh v1.6.1-1-gd4f1b84: Easy file sharing from the command line

I don't believe removing .git from the .dockerignore file is the correct solution for the repo though because then the container will be larger.

[aspacca]

I don't believe removing .git from the .dockerignore file is the correct solution for the repo though because then the container will be larger.

the final image is based on scratch, we can remove .git from the .dockerignore without having a bigger image. the .git folder will be copied only in the build stage of the image