GithubHelp home page GithubHelp logo

Comments (6)

sglyon avatar sglyon commented on May 18, 2024

Ahh I just noticed this the other day and was going to open an issue once I investigated more to find the issue.

Any thoughts on how to resolve?

from proton.

dvcrn avatar dvcrn commented on May 18, 2024
  1. We could blatantly enable everything before layer-init, but that would result that some of the needed packages are not there yet because the packages list could change after init.
  2. Layers could keep track if a package is disabled / enabled and remove it from get-packages
  3. We tweak enable/disable to save the package state and filter all disabled-packages (by proton) with all packages that layers need
  4. We provide a separate API that layers can use to disable / enable a package. Something like mark-enabled and mark-disabled. Core is then only enabling packages that are marked as enabled.

Just some thoughts

from proton.

geksilla avatar geksilla commented on May 18, 2024

I like 4.

We provide a separate API that layers can use to disable / enable a package. Something like mark-enabled and mark-disabled. Core is then only enabling packages that are marked as enabled.

from proton.

geksilla avatar geksilla commented on May 18, 2024

@dvcrn, I made experimental branch feel free to check it out.

from proton.

dvcrn avatar dvcrn commented on May 18, 2024

@geksilla very nice. I'll see if I can use this!

from proton.

dvcrn avatar dvcrn commented on May 18, 2024

Your change seem to have mostly fixed this. I am closing this issue.

from proton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.