modal dismiss about angular-modal-service

[changhuixu]

Same issue here. "close" promise doesn't remove DOM. Not sure why.
I do see it works well in demo page (http://dwmkerr.github.io/angular-modal-service/)...

[mskrzypkowski]

Probably you've attached some kind of $on on $rootScope and listener isn't destroyed - in my case it was socket.on of socket.io. See answer in this question: https://stackoverflow.com/questions/26487365/angularjs-ui-bootstrap-scope-not-disposed-after-modal-dismiss

[decherneyge]

Clicking the background is a dismissal of the modal and so it needs to resolve the close promise.
You will need to add a bootstrap modal hidden listener to the modals controller where the close promise is injected.

app.controller('SomeController', ['$scope', '$element', 'close', function ($scope, $element, close) {
    var myDismissedModalResult = {}; //prepare a result for when the modal is dismissed via the background click.
    
    //listen for when the modal is dismissed and resolve the ModalService Close promise
    $element.on('hidden.bs.modal', function (e) {
            close(myDismissedModalResult, 200); // close, but give 200ms for bootstrap to animate
        });

}]);

[dwmkerr]

Thanks to @decherneyge this is now in the bootstrap sample, so closing this issue now. Please re-open if needed!