Node-fetch & webpack about dwolla-v2-node

[shellscape]

@sausman please put some eyeballs on this. just ran into this today myself.

[sausman]

Hey @shellscape,

Yeah I’ll take a look at this. Any info you can provide on your setup to help reproduce would be great!

Are you using Webpack as well?

[shellscape]

@sausman yeah I actually work with @brianschardt but I was on another project with a similar setup. Typically shows up when node-fetch >= 2.0.0 gets the module resolution while bundling. Any version less than 2.0.0 doesn't have the issue. This is caused by a breaking change in 2.0.0 that didn't get much fanfare. See https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md#v200 and the last point under General changes.

https://www.npmjs.com/package/isomorphic-fetch might be a good option. should tree shake properly for bundlers. or, if the global scope of fetch doesn't sit well in Node, axios is a fine alternative which plays very nicely with bundlers and Node alike, with a similar syntax.

[sausman]

@shellscape Thanks that helps!

One thing I came across you may be able to use is https://www.npmjs.com/package/webpack-node-externals

It was apparently inspired by this blog post which mentions:

Webpack will load modules from the node_modules folder and bundle them in. This is fine for frontend code, but backend modules typically aren't prepared for this (i.e. using require in weird ways) or even worse are binary dependencies. We simply don't want to bundle in anything from node_modules.

[shellscape]

The one thing we do want to avoid is using externals. We're shipping to Lambda (serverless) and tree shaking the bajeezus out of the bundle to reduce the size of the archive. Avoiding shipping a node_modules directory is key.

[sausman]

Hey @shellscape,

We just published 3.1.2 which should fix this!

[shellscape]

🙌 and on your day off no less! Very much appreciated!