GithubHelp home page GithubHelp logo

Comments (4)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
Great work!  How do I apply this patch?

If it's easier I can give you SVN rights.  Let me know.

-Greg

Original comment by [email protected] on 15 Feb 2007 at 7:27

from pydelicious.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
You can manually apply my change via the 'patch' command line tool. Or if you 
give me
rights to SVN, I'll commit the changes myself. Before I do, two questions:

This changes the API; errors are no longer indicated by False, but rather 
something
other than True. I think in practice this is OK, do you?

8 of the tests fail when I run them with no username, the error is "HTTPError: 
HTTP
Error 401: Authorization Required". This fails in the trunk of SVN, not just my
modified copy. Do the tests pass for you?

Original comment by [email protected] on 15 Feb 2007 at 9:06

from pydelicious.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
You should have SVN commit/edit rights now.  Please let me know.  

I'm ok with your changes.  If you'd prefer to have the methods raise Errors on
failure, I'm ok with that too.

I think the tests actually need to be updated.  They may not be reflecting the
current state of the code.  Feel free to update those, otherwise I wouldn't 
worry
about them too much for the time being.

Original comment by [email protected] on 15 Feb 2007 at 10:20

from pydelicious.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
I've submitted my change; it's in revision 3.

Original comment by [email protected] on 15 Feb 2007 at 11:35

  • Changed state: Fixed

from pydelicious.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.