Comments (3)
Eventually I found:
triplevel
needs to be very, very close to 1.0.diffspace
needs to be about 1/256.
I'll go ahead and close the issue as there isn't a code bug -- but I'll also note that things that may be self-evident to the developers are not necessarily so for incoming users.
from frei0r.
frei0r plugin parameters support default values, the values you landed upon are very close to the defaults: https://mltframework.org/plugins/FilterFrei0r-cartoon/
I do not know if your Pd UI/integration supports frei0r default parameter values or resets them to something different. Over the past few years we have encouraged new plugin submissions to have a sensible mapping to the entire [0, 1] range of values, but older plugins such as this are not changed. Also, changing parameter behaviors can be problematic to the video editors that store these values in projects (as opposed to realtime tools) with respect to loading old projects in new versions of software. There is a version number on each plugin, but not many tools can or will have the code to adapt. So, changing the range mapping of existing parameters is frowned upon unless it is a critical fix. Adding new parameters with a different, overriding behavior is possible. But that can obviously be confusing to the user interface if it is a generically generated one, especially if it does not expose the parameter "description," which may contain information about this. Does Pd?
from frei0r.
I do not know if your Pd UI/integration supports frei0r default parameter values or resets them to something different.
It doesn't provide any information about defaults stored -- it prints the doc strings for the parameters but the default 0 to 1 values are not available programmatically using the pix_frei0r object.
So I see in the console window something like:
Cartoon: Cartoonify video, do a form of edge detect
triplevel: level of trip: mapped to [0,1] asymptotical
diffspace: difference space: a value from 0 to 256 (mapped to [0,1])
That's all.
I don't think there's any need to change the behavior of the parameters. I'm just pointing out that if one doesn't already know sensible ranges, it isn't obvious -- and documentation can address that. Specifically for Cartoon, it seems that triplevel may go further below 1 for higher values of diffspace. Intuitively this makes some sense, but it would be nice to have more detail on that (so that e.g. I could adjust the Pure Data slider ranges based on user values).
from frei0r.
Related Issues (20)
- π₯Όπ§ͺπ₯ static library build
- memleak in filter hqdn3d
- memleak in filter keyspillm0pup
- heap buffer overflow in filter curves HOT 1
- memleak in filter colortap
- Add color model for 32b float HOT 2
- pixs0r filter outputs blank rows
- Need help with backporting recent commits for Flathub maintainers HOT 3
- Links to applications using frei0r needs updating
- recent renaming commits breaking compatibility HOT 2
- clang-format the C and C++ source code HOT 2
- Lack of kaleidoscope filter HOT 6
- Unlock freshcode.club frei0r login HOT 1
- v2.3.1 build fails when cross-compiling for Windows via mingw. See build log in comments. HOT 6
- import bigsh0t
- Explain project name in readme
- Protobuf duplicate library causes mlt to crash HOT 3
- Usage of Windows build unclear ? HOT 3
- frei0r-mixer-overlay and blend segfault
- thread safety HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frei0r.