GithubHelp home page GithubHelp logo

Subscribe about vest HOT 6 CLOSED

vonagam avatar vonagam commented on September 24, 2024
Subscribe

from vest.

Comments (6)

ealush avatar ealush commented on September 24, 2024 1

That's actually something I've had in mind for a while.

I was working (then abandoned) on a vest devtools extension that relies on that, so if you look up 2 year old branches, you'll find reference to exactly that (built upon the vest bus).

I think I can add that, but it will be a few days, since I am currently at a conference abroad.

If you want to submit a PR, feel free to do so. I'll gladly review it.

What I had in mind is:

Suite.subscribe(cb)

Cb will receive as arguments:

  • Event name
  • Event payload

from vest.

ealush avatar ealush commented on September 24, 2024 1

Shipped in 5.1.0. Closing.

from vest.

ealush avatar ealush commented on September 24, 2024

Thinking of it again, the event payload may not even be needed in this case, and we can decide not to add it for now. It is enough to know about the event, and then you can pull whatever data you need directly from the suite. No need to expose the internals there.

from vest.

ealush avatar ealush commented on September 24, 2024

@vonagam, let me know if you want to take it. Otherwise, I'll implement it.

from vest.

vonagam avatar vonagam commented on September 24, 2024

the event payload may not even be needed in this case

Ye, for my use case it is not needed.

let me know if you want to take it. Otherwise, I'll implement it.

Do it. (I usually contribute when I become impatient from waiting too long for a thing that I need but you are super fast with responses and have the full picture in mind so I consider it a better choice.)

from vest.

ealush avatar ealush commented on September 24, 2024

Hey @vonagam, created this PR. #1080
Please take a look at it. If this looks like what you had in mind as well, I'll release it as part of 5.1.0.

from vest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.