Comments (6)
Just a note here that we are getting a warning about github3's import of collections (when running our tests) that will become an error with python 3.9. This is fixed on their master branch, but they haven't done a release since 2018. It does look like there has been some recent activity on the github3 project, so maybe it is getting going again?
/usr/local/miniconda3/envs/abc/lib/python3.8/site-packages/github3/structs.py:11
/usr/local/miniconda3/envs/abc/lib/python3.8/site-packages/github3/structs.py:11: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
class GitHubIterator(models.GitHubCore, collections.Iterator):
from abc-classroom.
oooh. could be worth opening an issue just to check that they plan to update accordingly??
from abc-classroom.
@kcranston @nkorinek i just checked. A release for github3 was pushed to pypi and conda-forge in 2021. it fixes that error. I think we should decide whether we want to use it vs subprocess or pygithub before we really dig into tests as it will impact how we collect responses. in some cases the returned information could be formatted differently between packages for example.
karen, let me know what you think. the last commit to github3.py was 2 days ago. i just haven't taken the time to compare the two packages. we should make a decision and then close this issue and focus on tests!
from abc-classroom.
i'm adding this to the tests for git operations milestone
from abc-classroom.
Given the small number of API calls, I don't think we need a dependency on a github library at all. I suggest we get rid of github3 and simply call the APIs using requests.
from abc-classroom.
@kcranston @nkorinek this can be closed when you submit the change we talked about today with updating dependencies. please reference this issue 72 when you submit so we can close it
from abc-classroom.
Related Issues (20)
- implement logging
- Package organization HOT 1
- Organization of github and git functions in abc classroom HOT 4
- Test suites and organization HOT 1
- Clean up old / deprecated code HOT 1
- potential bug? - github.remote_repo_exists returns false with bad token even if repo exists. HOT 2
- break up get_access_token into two helpers? HOT 2
- set_github_auth will fail if no file is found HOT 2
- Docstring Updates
- Function that may not get used anywhere in abc classroom HOT 2
- function init_and_commit and custom commit messages HOT 7
- Struggling to trigger FileNotFound Error in get_github_auth() HOT 1
- Better error handling for auth setup
- 403 You need admin access to the organization before adding a repository to it. HOT 7
- Do we want to keep python 3.6 support & docs build HOT 2
- What's next for abc-classroom - test suite
- abc-init fails getting access token HOT 16
- No support for multiple ssh users
- Copy an entire directory tree from extra_files
- Misleading setup documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abc-classroom.