GithubHelp home page GithubHelp logo

Comments (6)

kcranston avatar kcranston commented on July 2, 2024

Just a note here that we are getting a warning about github3's import of collections (when running our tests) that will become an error with python 3.9. This is fixed on their master branch, but they haven't done a release since 2018. It does look like there has been some recent activity on the github3 project, so maybe it is getting going again?

/usr/local/miniconda3/envs/abc/lib/python3.8/site-packages/github3/structs.py:11
  /usr/local/miniconda3/envs/abc/lib/python3.8/site-packages/github3/structs.py:11: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    class GitHubIterator(models.GitHubCore, collections.Iterator):

from abc-classroom.

lwasser avatar lwasser commented on July 2, 2024

oooh. could be worth opening an issue just to check that they plan to update accordingly??

from abc-classroom.

lwasser avatar lwasser commented on July 2, 2024

@kcranston @nkorinek i just checked. A release for github3 was pushed to pypi and conda-forge in 2021. it fixes that error. I think we should decide whether we want to use it vs subprocess or pygithub before we really dig into tests as it will impact how we collect responses. in some cases the returned information could be formatted differently between packages for example.

karen, let me know what you think. the last commit to github3.py was 2 days ago. i just haven't taken the time to compare the two packages. we should make a decision and then close this issue and focus on tests!

from abc-classroom.

lwasser avatar lwasser commented on July 2, 2024

i'm adding this to the tests for git operations milestone

from abc-classroom.

kcranston avatar kcranston commented on July 2, 2024

Given the small number of API calls, I don't think we need a dependency on a github library at all. I suggest we get rid of github3 and simply call the APIs using requests.

from abc-classroom.

lwasser avatar lwasser commented on July 2, 2024

@kcranston @nkorinek this can be closed when you submit the change we talked about today with updating dependencies. please reference this issue 72 when you submit so we can close it

from abc-classroom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.