Comments (2)
the hash is inserted when this call is made:
earthly/earthfile2llb/interpreter.go
Line 1294 in 1b3bfd4
calling this here is incorrect, since the Build
function doesn't actually perform a build (i.e. by calling forceExecution
), but instead is simply for converting the BUILD command into the appropriate LLB.
This code has an additional bug where the platform type doesn't seem to be used in calculating the hash.
If the hash is platform agnostic (which might make sense since we need to be careful when pushing multi-platform images), it seems like we need to wait for all platforms to build (execute) correctly before saving the hash.
from earthly.
Note that this can still be replicated with:
VERSION --build-auto-skip 0.8
foo:
FROM alpine
RUN echo "running under $(uname -m)" && if [ "$(uname -m)" = "x86_64" ]; then sleep 15 && exit 1; fi
SAVE IMAGE mytest:latest
test:
BUILD --auto-skip --platform=linux/arm64 +foo
BUILD --auto-skip --platform=linux/amd64 +foo
and running:
rm -f test.db; ~/gh/earthly/earthly/build/linux/amd64/earthly prune --reset; ~/gh/earthly/earthly/build/linux/amd64/earthly --auto-skip-db-path=test.db --auto-skip +test; ~/gh/earthly/earthly/build/linux/amd64/earthly --auto-skip-db-path=test.db --auto-skip +test;
from earthly.
Related Issues (20)
- Create matrix builds from CLI arguments HOT 1
- `RUN --interactive` triggers HTTP 500 when used `WITH DOCKER --load` HOT 1
- Can I `COPY` artifacts from a matrix build? HOT 2
- `--pass-args` busts cache unexpected HOT 8
- DIND networking dont work when using non standard CNI_MTU
- `TRY` / `FINALLY` when used with `WITH DOCKER` produces verbose output HOT 3
- Earthly doesn't respect a host defined in a local `/etc/hosts` file when doing SAVE IMAGE HOT 2
- ticktock cache issue HOT 3
- `TRY` / `FINALLY` doesn't work under `WITH DOCKER`
- error message for WITH DOCKER (unlazy force execution) could be improved HOT 1
- self-hosted registry reachable from host machine but dns look up failed inside earthly HOT 2
- `+base` target should only be run when necessary
- Running TestContainers in Earthly fails to find Docker Daemon HOT 4
- `docker network create --internal` can fail with a ` network with name ... already exists` error when `WITH DOCKER --cache-id=` is used HOT 2
- BuildKit: Snapshot directory does not exist HOT 1
- `exporting output` message is unclear and appears when earthly is run with the `--no-output` flag
- Error DX improvement suggestion: Verbose lexer error
- how to run the `earthly-buildkitd` container under `--network=host` mode HOT 1
- proposal: `TEST` command HOT 3
- Any support planned for ONBUILD?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from earthly.