GithubHelp home page GithubHelp logo

Comments (3)

idelvall avatar idelvall commented on September 16, 2024

Hi Adam, thanks!
The original implementation worked that that way, but we soon realized that the target cache grew significantly even with cargo-sweep installed (more than 10GB in some cases), so we were not adding significant runtime overhead by copying all the files (most of then not needed), we were also significantly polluting the build layer cache.
Another thing I considered was instead of adding an "--output" option add a "--save-artifact" one, so no need for redundant information, but I think this is cleaner

from lib.

adamgordonbell avatar adamgordonbell commented on September 16, 2024

Makes sense.
I'm just talking about a default. So you could still use the output flag, but if you didn't, you wouldn't be surprised that you ended up with no files. Keep in mind the user of the UDC has no idea how it works internally and probably just wants the output of their cargo call.

Maybe its too early to say. If other people use it and get tripped up by this it might make sense to consider.

from lib.

idelvall avatar idelvall commented on September 16, 2024

The output is an ARG in the UDC, so it's not an implementation detail, but even if a user ignores what it does,
I think it's better to force them to read the API documentation by don't outputting anything, rather than giving them the output without being aware of the side effects of that as the cache grows.
At least that is what I would prefer, but yes, let's wait to see how people react to all of this.

Thanks Adam!

from lib.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.